public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval R <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/2] ui: ipview: Use monospace font for IPs and MAC addresses
Date: Thu, 16 Nov 2023 14:13:29 +0100	[thread overview]
Message-ID: <20231116131330.164838-1-m.sandoval@proxmox.com> (raw)

It becomes easier to read when you have multiple rows showing MACs when
they have the same size.

Signed-off-by: Maximiliano Sandoval R <m.sandoval@proxmox.com>
---
 www/manager6/qemu/AgentIPView.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/www/manager6/qemu/AgentIPView.js b/www/manager6/qemu/AgentIPView.js
index 1411361a..1567bb42 100644
--- a/www/manager6/qemu/AgentIPView.js
+++ b/www/manager6/qemu/AgentIPView.js
@@ -22,13 +22,17 @@ Ext.define('PVE.window.IPInfo', {
 		    dataIndex: 'hardware-address',
 		    text: gettext('MAC address'),
 		    width: 140,
+		    renderer: function(val, metaData) {
+			metaData.style += 'font-family: monospace;';
+			return val;
+		    },
 		},
 		{
 		    dataIndex: 'ip-addresses',
 		    text: gettext('IP address'),
 		    align: 'right',
 		    flex: 4,
-		    renderer: function(val) {
+		    renderer: function(val, metaData) {
 			if (!Ext.isArray(val)) {
 			    return '';
 			}
@@ -40,6 +44,7 @@ Ext.define('PVE.window.IPInfo', {
 				ips.push(addr + '/' + pref);
 			    }
 			});
+			metaData.style += 'font-family: monospace;';
 			return ips.join('<br>');
 		    },
 		},
-- 
2.39.2





             reply	other threads:[~2023-11-16 13:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-16 13:13 Maximiliano Sandoval R [this message]
2023-11-16 13:13 ` [pve-devel] [PATCH manager 2/2] ui: ipview: Increase the width of the MAC column Maximiliano Sandoval R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231116131330.164838-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal