From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC qemu-server/common] fix #4501: improve port reservation for QEMU TCP migration
Date: Tue, 14 Nov 2023 15:02:01 +0100 [thread overview]
Message-ID: <20231114140204.27679-1-f.ebner@proxmox.com> (raw)
Each patch is a different approach for improving the situation and
each subset could be applied. Personally, I like common 2/2, because
it removes the competition for early ports and IMHO the only one
worth considering a full fix, but it is a bit complex.
Another approach (not in the RFC, also could be considered a full fix)
would be to opt-in for a higher expire time for migration ports, add a
mechanism to remove the reservation and have vm_start_nolock() remove
the reservation after it made sure that QEMU got the port.
qemu-server:
Fiona Ebner (1):
partially fix #4501: migration: start vm: move port reservation and
usage closer together
PVE/QemuServer.pm | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
common:
Fiona Ebner (2):
partially fix #4501: next unused port: bump port reservation
expiretime
fix #4501: next unused port: work around issue with too short
expiretime
src/PVE/Tools.pm | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
--
2.39.2
next reply other threads:[~2023-11-14 14:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 14:02 Fiona Ebner [this message]
2023-11-14 14:02 ` [pve-devel] [RFC qemu-server 1/1] partially fix #4501: migration: start vm: move port reservation and usage closer together Fiona Ebner
2023-11-15 8:55 ` Fabian Grünbichler
2023-11-15 10:12 ` Wolfgang Bumiller
2023-11-15 10:22 ` Fiona Ebner
2023-11-15 11:21 ` Wolfgang Bumiller
2023-11-14 14:02 ` [pve-devel] [RFC common 1/2] partially fix #4501: next unused port: bump port reservation expiretime Fiona Ebner
2023-11-15 8:51 ` Fabian Grünbichler
2023-11-14 14:02 ` [pve-devel] [RFC common 2/2] fix #4501: next unused port: work around issue with too short expiretime Fiona Ebner
2023-11-14 14:13 ` Fiona Ebner
2023-11-15 8:51 ` Fabian Grünbichler
2023-11-15 10:16 ` Fiona Ebner
2023-11-15 10:27 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114140204.27679-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox