* [pve-devel] [PATCH manager 1/3] ui: resource tree: don't save the tooltip
@ 2023-11-10 10:12 Dominik Csapak
2023-11-10 10:12 ` [pve-devel] [PATCH manager 2/3] ui: resource tree: fix showing empty tooltips Dominik Csapak
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dominik Csapak @ 2023-11-10 10:12 UTC (permalink / raw)
To: pve-devel
it shouldn't be called that often, and if we save it, it gets outdated,
e.g. when starting/stopping a guest
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/tree/ResourceTree.js | 3 ---
1 file changed, 3 deletions(-)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index 90f85fba..3d2dd931 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -135,9 +135,6 @@ Ext.define('PVE.tree.ResourceTree', {
},
getToolTip: function(info) {
- if (info.tip) {
- return info.tip;
- }
if (info.type === 'pool' || info.groupbyid !== undefined) {
return undefined;
}
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH manager 2/3] ui: resource tree: fix showing empty tooltips
2023-11-10 10:12 [pve-devel] [PATCH manager 1/3] ui: resource tree: don't save the tooltip Dominik Csapak
@ 2023-11-10 10:12 ` Dominik Csapak
2023-11-10 10:13 ` [pve-devel] [PATCH manager 3/3] ui: resource tree: add usage percentage to storage tooltip Dominik Csapak
2023-11-12 17:13 ` [pve-devel] applied-series: [PATCH manager 1/3] ui: resource tree: don't save the tooltip Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Dominik Csapak @ 2023-11-10 10:12 UTC (permalink / raw)
To: pve-devel
stop the tooltip show when the there is no text
this could happen for e.g. nodes that should not have a tooltip
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/tree/ResourceTree.js | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index 3d2dd931..ed51ac32 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -417,7 +417,12 @@ Ext.define('PVE.tree.ResourceTree', {
listeners: {
beforeshow: function(tip) {
let rec = me.getView().getRecord(tip.triggerElement);
- tip.update(me.getToolTip(rec.data));
+ let tipText = me.getToolTip(rec.data);
+ if (tipText) {
+ tip.update(tipText);
+ return true;
+ }
+ return false;
},
},
});
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH manager 3/3] ui: resource tree: add usage percentage to storage tooltip
2023-11-10 10:12 [pve-devel] [PATCH manager 1/3] ui: resource tree: don't save the tooltip Dominik Csapak
2023-11-10 10:12 ` [pve-devel] [PATCH manager 2/3] ui: resource tree: fix showing empty tooltips Dominik Csapak
@ 2023-11-10 10:13 ` Dominik Csapak
2023-11-12 17:13 ` [pve-devel] applied-series: [PATCH manager 1/3] ui: resource tree: don't save the tooltip Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Dominik Csapak @ 2023-11-10 10:13 UTC (permalink / raw)
To: pve-devel
it is a bit more verbose than the usage bar
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/tree/ResourceTree.js | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index ed51ac32..acfa545a 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -146,6 +146,12 @@ Ext.define('PVE.tree.ResourceTree', {
if (info.hastate !== 'unmanaged') {
qtips.push(gettext('HA State') + ": " + info.hastate);
}
+ if (info.type === 'storage') {
+ let usage = info.disk / info.maxdisk;
+ if (usage >= 0.0 && usage <= 1.0) {
+ qtips.push(Ext.String.format(gettext("Usage: {0}%"), (usage*100).toFixed(2)));
+ }
+ }
let tip = qtips.join(', ');
info.tip = tip;
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied-series: [PATCH manager 1/3] ui: resource tree: don't save the tooltip
2023-11-10 10:12 [pve-devel] [PATCH manager 1/3] ui: resource tree: don't save the tooltip Dominik Csapak
2023-11-10 10:12 ` [pve-devel] [PATCH manager 2/3] ui: resource tree: fix showing empty tooltips Dominik Csapak
2023-11-10 10:13 ` [pve-devel] [PATCH manager 3/3] ui: resource tree: add usage percentage to storage tooltip Dominik Csapak
@ 2023-11-12 17:13 ` Thomas Lamprecht
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2023-11-12 17:13 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 10/11/2023 um 11:12 schrieb Dominik Csapak:
> it shouldn't be called that often, and if we save it, it gets outdated,
> e.g. when starting/stopping a guest
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/tree/ResourceTree.js | 3 ---
> 1 file changed, 3 deletions(-)
>
>
applied all three patches, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-12 17:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-10 10:12 [pve-devel] [PATCH manager 1/3] ui: resource tree: don't save the tooltip Dominik Csapak
2023-11-10 10:12 ` [pve-devel] [PATCH manager 2/3] ui: resource tree: fix showing empty tooltips Dominik Csapak
2023-11-10 10:13 ` [pve-devel] [PATCH manager 3/3] ui: resource tree: add usage percentage to storage tooltip Dominik Csapak
2023-11-12 17:13 ` [pve-devel] applied-series: [PATCH manager 1/3] ui: resource tree: don't save the tooltip Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox