From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/3] ui: resource tree: fix showing empty tooltips
Date: Fri, 10 Nov 2023 11:12:59 +0100 [thread overview]
Message-ID: <20231110101300.2506389-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20231110101300.2506389-1-d.csapak@proxmox.com>
stop the tooltip show when the there is no text
this could happen for e.g. nodes that should not have a tooltip
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/tree/ResourceTree.js | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index 3d2dd931..ed51ac32 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -417,7 +417,12 @@ Ext.define('PVE.tree.ResourceTree', {
listeners: {
beforeshow: function(tip) {
let rec = me.getView().getRecord(tip.triggerElement);
- tip.update(me.getToolTip(rec.data));
+ let tipText = me.getToolTip(rec.data);
+ if (tipText) {
+ tip.update(tipText);
+ return true;
+ }
+ return false;
},
},
});
--
2.30.2
next prev parent reply other threads:[~2023-11-10 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 10:12 [pve-devel] [PATCH manager 1/3] ui: resource tree: don't save the tooltip Dominik Csapak
2023-11-10 10:12 ` Dominik Csapak [this message]
2023-11-10 10:13 ` [pve-devel] [PATCH manager 3/3] ui: resource tree: add usage percentage to storage tooltip Dominik Csapak
2023-11-12 17:13 ` [pve-devel] applied-series: [PATCH manager 1/3] ui: resource tree: don't save the tooltip Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110101300.2506389-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox