From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 manager 4/4] ui: backup job: disable zstd thread count field when zstd isn't used
Date: Tue, 7 Nov 2023 14:49:27 +0100 [thread overview]
Message-ID: <20231107134928.81303-5-f.ebner@proxmox.com> (raw)
In-Reply-To: <20231107134928.81303-1-f.ebner@proxmox.com>
Also need to check for enable/disable of the compression selector,
because with PBS the value zstd is set, but the thread count setting
doesn't apply.
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
No changes in v3.
www/manager6/dc/Backup.js | 18 ++++++++++++++++++
www/manager6/panel/BackupPerformance.js | 13 +++++++++++++
2 files changed, 31 insertions(+)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 1b2f95d2..17dbe345 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -161,6 +161,18 @@ Ext.define('PVE.dc.BackupEdit', {
}
},
+ compressionChange: function(f, value, oldValue) {
+ this.getView().lookup('backupPerformance').updateCompression(value, f.isDisabled());
+ },
+
+ compressionDisable: function(f) {
+ this.getView().lookup('backupPerformance').updateCompression(f.getValue(), true);
+ },
+
+ compressionEnable: function(f) {
+ this.getView().lookup('backupPerformance').updateCompression(f.getValue(), false);
+ },
+
init: function(view) {
let me = this;
if (view.isCreate) {
@@ -380,6 +392,11 @@ Ext.define('PVE.dc.BackupEdit', {
deleteEmpty: '{!isCreate}',
},
value: 'zstd',
+ listeners: {
+ change: 'compressionChange',
+ disable: 'compressionDisable',
+ enable: 'compressionEnable',
+ },
},
{
xtype: 'pveBackupModeSelector',
@@ -494,6 +511,7 @@ Ext.define('PVE.dc.BackupEdit', {
},
{
xtype: 'pveBackupPerformancePanel',
+ reference: 'backupPerformance',
title: gettext('Performance'),
cbind: {
isCreate: '{isCreate}',
diff --git a/www/manager6/panel/BackupPerformance.js b/www/manager6/panel/BackupPerformance.js
index 6680754a..a9d6a1fb 100644
--- a/www/manager6/panel/BackupPerformance.js
+++ b/www/manager6/panel/BackupPerformance.js
@@ -12,6 +12,10 @@ Ext.define('PVE.panel.BackupPerformance', {
return {};
},
+ controller: {
+ xclass: 'Ext.app.ViewController',
+ },
+
onGetValues: function(formValues) {
if (this.needMask) { // isMasked() may not yet be true if not rendered once
return {};
@@ -54,6 +58,14 @@ Ext.define('PVE.panel.BackupPerformance', {
return options;
},
+ updateCompression: function(value, disabled) {
+ if (!disabled && value === 'zstd') {
+ this.lookup('zstdThreadCount').setDisabled(false);
+ } else {
+ this.lookup('zstdThreadCount').setDisabled(true);
+ }
+ },
+
column1: [
{
xtype: 'pveBandwidthField',
@@ -71,6 +83,7 @@ Ext.define('PVE.panel.BackupPerformance', {
{
xtype: 'proxmoxintegerfield',
name: 'zstd',
+ reference: 'zstdThreadCount',
fieldLabel: Ext.String.format(gettext('{0} Threads'), 'Zstd'),
fieldStyle: 'text-align: right',
emptyText: gettext('use fallback'),
--
2.39.2
next prev parent reply other threads:[~2023-11-07 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:49 [pve-devel] [PATCH-SERIES v3 manager/docs] close #4513: add performance tab for backup jobs Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 manager 1/4] vzdump: actually honor schema defaults for performance Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 manager 2/4] vzdump: use per-property fallback for performance settings Fiona Ebner
2023-11-07 13:49 ` [pve-devel] [PATCH v3 manager 3/4] close #4513: ui: backup job: add performance tab Fiona Ebner
2023-11-07 13:49 ` Fiona Ebner [this message]
2023-11-07 13:49 ` [pve-devel] [PATCH v3 docs 5/5] backup: update information about performance settings Fiona Ebner
2024-03-25 14:09 ` [pve-devel] [PATCH-SERIES v3 manager/docs] close #4513: add performance tab for backup jobs Fiona Ebner
2024-04-16 10:16 ` Thomas Lamprecht
2024-04-16 12:11 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107134928.81303-5-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox