From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-manager 11/27] api: notification: remove notification groups
Date: Tue, 7 Nov 2023 11:18:11 +0100 [thread overview]
Message-ID: <20231107101827.340100-12-l.wagner@proxmox.com> (raw)
In-Reply-To: <20231107101827.340100-1-l.wagner@proxmox.com>
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
PVE/API2/Cluster/Notifications.pm | 267 +-----------------------------
1 file changed, 4 insertions(+), 263 deletions(-)
diff --git a/PVE/API2/Cluster/Notifications.pm b/PVE/API2/Cluster/Notifications.pm
index ec666903..b34802c8 100644
--- a/PVE/API2/Cluster/Notifications.pm
+++ b/PVE/API2/Cluster/Notifications.pm
@@ -121,7 +121,6 @@ __PACKAGE__->register_method ({
my $result = [
{ name => 'endpoints' },
{ name => 'filters' },
- { name => 'groups' },
{ name => 'targets' },
];
@@ -161,8 +160,7 @@ __PACKAGE__->register_method ({
name => 'get_all_targets',
path => 'targets',
method => 'GET',
- description => 'Returns a list of all entities that can be used as notification targets' .
- ' (endpoints and groups).',
+ description => 'Returns a list of all entities that can be used as notification targets.',
permissions => {
description => "Only lists entries where you have 'Mapping.Modify', 'Mapping.Use' or"
. " 'Mapping.Audit' permissions on '/mapping/notification/<name>'."
@@ -180,14 +178,14 @@ __PACKAGE__->register_method ({
type => 'object',
properties => {
name => {
- description => 'Name of the endpoint/group.',
+ description => 'Name of the target.',
type => 'string',
format => 'pve-configid',
},
'type' => {
- description => 'Type of the endpoint or group.',
+ description => 'Type of the target.',
type => 'string',
- enum => [qw(sendmail gotify group)],
+ enum => [qw(sendmail gotify)],
},
'comment' => {
description => 'Comment',
@@ -221,14 +219,6 @@ __PACKAGE__->register_method ({
};
}
- for my $target (@{$config->get_groups()}) {
- push @$result, {
- name => $target->{name},
- comment => $target->{comment},
- type => 'group',
- };
- }
-
$result
};
@@ -290,255 +280,6 @@ __PACKAGE__->register_method ({
}
});
-my $group_properties = {
- name => {
- description => 'Name of the group.',
- type => 'string',
- format => 'pve-configid',
- },
- 'endpoint' => {
- type => 'array',
- items => {
- type => 'string',
- format => 'pve-configid',
- },
- description => 'List of included endpoints',
- },
- 'comment' => {
- description => 'Comment',
- type => 'string',
- optional => 1,
- },
- filter => {
- description => 'Name of the filter that should be applied.',
- type => 'string',
- format => 'pve-configid',
- optional => 1,
- },
-};
-
-__PACKAGE__->register_method ({
- name => 'get_groups',
- path => 'groups',
- method => 'GET',
- description => 'Returns a list of all groups',
- protected => 1,
- permissions => {
- description => "Only lists entries where you have 'Mapping.Modify', 'Mapping.Use' or"
- . " 'Mapping.Audit' permissions on '/mapping/notification/<name>'.",
- user => 'all',
- },
- parameters => {
- additionalProperties => 0,
- properties => {},
- },
- returns => {
- type => 'array',
- items => {
- type => 'object',
- properties => $group_properties,
- },
- links => [ { rel => 'child', href => '{name}' } ],
- },
- code => sub {
- my $config = PVE::Notify::read_config();
- my $rpcenv = PVE::RPCEnvironment::get();
-
- my $entities = eval {
- $config->get_groups();
- };
- raise_api_error($@) if $@;
-
- return filter_entities_by_privs($rpcenv, $entities);
- }
-});
-
-__PACKAGE__->register_method ({
- name => 'get_group',
- path => 'groups/{name}',
- method => 'GET',
- description => 'Return a specific group',
- protected => 1,
- permissions => {
- check => ['or',
- ['perm', '/mapping/notification/{name}', ['Mapping.Modify']],
- ['perm', '/mapping/notification/{name}', ['Mapping.Audit']],
- ],
- },
- parameters => {
- additionalProperties => 0,
- properties => {
- name => {
- type => 'string',
- format => 'pve-configid',
- },
- }
- },
- returns => {
- type => 'object',
- properties => {
- %$group_properties,
- digest => get_standard_option('pve-config-digest'),
- },
- },
- code => sub {
- my ($param) = @_;
- my $name = extract_param($param, 'name');
-
- my $config = PVE::Notify::read_config();
-
- my $group = eval {
- $config->get_group($name)
- };
-
- raise_api_error($@) if $@;
- $group->{digest} = $config->digest();
-
- return $group;
- }
-});
-
-__PACKAGE__->register_method ({
- name => 'create_group',
- path => 'groups',
- protected => 1,
- method => 'POST',
- description => 'Create a new group',
- permissions => {
- check => ['perm', '/mapping/notification', ['Mapping.Modify']],
- },
- parameters => {
- additionalProperties => 0,
- properties => $group_properties,
- },
- returns => { type => 'null' },
- code => sub {
- my ($param) = @_;
-
- my $name = extract_param($param, 'name');
- my $endpoint = extract_param($param, 'endpoint');
- my $comment = extract_param($param, 'comment');
- my $filter = extract_param($param, 'filter');
-
- eval {
- PVE::Notify::lock_config(sub {
- my $config = PVE::Notify::read_config();
-
- $config->add_group(
- $name,
- $endpoint,
- $comment,
- $filter,
- );
-
- PVE::Notify::write_config($config);
- });
- };
-
- raise_api_error($@) if $@;
- return;
- }
-});
-
-__PACKAGE__->register_method ({
- name => 'update_group',
- path => 'groups/{name}',
- protected => 1,
- method => 'PUT',
- description => 'Update existing group',
- permissions => {
- check => ['perm', '/mapping/notification/{name}', ['Mapping.Modify']],
- },
- parameters => {
- additionalProperties => 0,
- properties => {
- %{ make_properties_optional($group_properties) },
- delete => {
- type => 'array',
- items => {
- type => 'string',
- format => 'pve-configid',
- },
- optional => 1,
- description => 'A list of settings you want to delete.',
- },
- digest => get_standard_option('pve-config-digest'),
- },
- },
- returns => { type => 'null' },
- code => sub {
- my ($param) = @_;
-
- my $name = extract_param($param, 'name');
- my $endpoint = extract_param($param, 'endpoint');
- my $comment = extract_param($param, 'comment');
- my $filter = extract_param($param, 'filter');
- my $digest = extract_param($param, 'digest');
- my $delete = extract_param($param, 'delete');
-
- eval {
- PVE::Notify::lock_config(sub {
- my $config = PVE::Notify::read_config();
-
- $config->update_group(
- $name,
- $endpoint,
- $comment,
- $filter,
- $delete,
- $digest,
- );
-
- PVE::Notify::write_config($config);
- });
- };
-
- raise_api_error($@) if $@;
- return;
- }
-});
-
-__PACKAGE__->register_method ({
- name => 'delete_group',
- protected => 1,
- path => 'groups/{name}',
- method => 'DELETE',
- description => 'Remove group',
- permissions => {
- check => ['perm', '/mapping/notification/{name}', ['Mapping.Modify']],
- },
- parameters => {
- additionalProperties => 0,
- properties => {
- name => {
- type => 'string',
- format => 'pve-configid',
- },
- }
- },
- returns => { type => 'null' },
- code => sub {
- my ($param) = @_;
- my $name = extract_param($param, 'name');
-
- my $used_by = target_used_by($name);
- if ($used_by) {
- raise_param_exc({'name' => "Cannot remove $name, used by: $used_by"});
- }
-
- eval {
- PVE::Notify::lock_config(sub {
- my $config = PVE::Notify::read_config();
- $config->delete_group($name);
- PVE::Notify::write_config($config);
- });
- };
-
- raise_api_error($@) if $@;
- return;
- }
-});
-
my $sendmail_properties = {
name => {
description => 'The name of the endpoint.',
--
2.39.2
next prev parent reply other threads:[~2023-11-07 10:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 10:18 [pve-devel] [PATCH many 00/27] overhaul notification system, use matchers instead of filters Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox 01/27] notify: introduce Error::Generic Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox 02/27] notify: factor out notification content into its own type Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox 03/27] notify: replace filters and groups with matcher-based system Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox 04/27] notify: add calendar matcher Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox 05/27] notify: matcher: introduce common trait for match directives Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox 06/27] notify: let a matcher always match if it has no matching directives Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-perl-rs 07/27] notify: adapt to new matcher-based notification routing Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-cluster 08/27] notify: adapt to matcher based notification system Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-guest-common 09/27] vzdump: deprecate mailto/mailnotification/notification-{target, policy} Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-ha-manager 10/27] env: switch to matcher-based notification system Lukas Wagner
2023-11-07 10:18 ` Lukas Wagner [this message]
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 12/27] api: notification: add new matcher-based notification API Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 13/27] ui: dc: remove unneeded notification events panel Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 14/27] vzdump: adapt to new matcher based notification system Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 15/27] api: apt: adapt to matcher-based notifications Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 16/27] api: replication: adapt to matcher-based notification system Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 17/27] debian: postinst: create notifications.cfg if it does not exist Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 18/27] test: fix vzdump notification test Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 19/27] ui: vzdump: remove left-overs from target/policy based notifications Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH pve-manager 20/27] ui: dc: config: show notification panel again Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-widget-toolkit 21/27] notification ui: add target selector for matcher Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-widget-toolkit 22/27] notification ui: remove filter setting for targets Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-widget-toolkit 23/27] notification ui: remove notification groups Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-widget-toolkit 24/27] notification ui: rename filter to matcher Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-widget-toolkit 25/27] notification: matcher: add UI for matcher editing Lukas Wagner
2023-11-13 15:13 ` Dominik Csapak
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-widget-toolkit 26/27] notification ui: unprotected mailto-root target Lukas Wagner
2023-11-07 10:18 ` [pve-devel] [PATCH proxmox-widget-toolkit 27/27] noficiation: matcher edit: make 'field' an editable combobox Lukas Wagner
2023-11-13 14:34 ` [pve-devel] [PATCH many 00/27] overhaul notification system, use matchers instead of filters Dominik Csapak
2023-11-13 14:54 ` Thomas Lamprecht
2023-11-13 14:58 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107101827.340100-12-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox