From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ui: BulkAction: add clear filters button
Date: Mon, 30 Oct 2023 13:58:11 +0100 [thread overview]
Message-ID: <20231030125811.11759-2-d.csapak@proxmox.com> (raw)
In-Reply-To: <20231030125811.11759-1-d.csapak@proxmox.com>
to be able to clear all of them at once
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
sending this as a separate patch since i'm not sure if the button is
worth it. if deemed appropriate could also be squashed into the previous
patch
www/manager6/window/BulkAction.js | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js
index 333d5d30..44171390 100644
--- a/www/manager6/window/BulkAction.js
+++ b/www/manager6/window/BulkAction.js
@@ -162,6 +162,13 @@ Ext.define('PVE.window.BulkAction', {
let tagList = Object.keys(tagMap).map(key => ({ value: key }));
let haList = Object.keys(haMap).map(key => [key, key]);
+ let clearFilters = function() {
+ me.down('#namefilter').setValue('');
+ ['name', 'status', 'pool', 'type', 'hastate', 'includetag', 'excludetag', 'vmid'].forEach((filter) => {
+ me.down(`#${filter}filter`).setValue('');
+ });
+ };
+
let filterChange = function() {
let nameValue = me.down('#namefilter').getValue();
let filterCount = 0;
@@ -192,10 +199,13 @@ Ext.define('PVE.window.BulkAction', {
}
let fieldSet = me.down('#filters');
+ let clearBtn = me.down('#clearBtn');
if (filterCount) {
fieldSet.setTitle(Ext.String.format(gettext('Filters ({0})'), filterCount));
+ clearBtn.setDisabled(false);
} else {
fieldSet.setTitle(gettext('Filters'));
+ clearBtn.setDisabled(true);
}
let filterFn = function(value) {
@@ -383,6 +393,22 @@ Ext.define('PVE.window.BulkAction', {
change: filterChange,
},
},
+ {
+ xtype: 'container',
+ layout: {
+ type: 'vbox',
+ align: 'end',
+ },
+ items: [
+ {
+ xtype: 'button',
+ itemId: 'clearBtn',
+ text: gettext('Clear Filters'),
+ disabled: true,
+ handler: clearFilters,
+ },
+ ],
+ },
],
},
],
--
2.39.2
next prev parent reply other threads:[~2023-10-30 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 12:58 [pve-devel] [PATCH manager 1/2] ui: BulkActions: rework filters and include tags Dominik Csapak
2023-10-30 12:58 ` Dominik Csapak [this message]
2023-11-06 16:01 ` Thomas Lamprecht
2023-11-08 12:14 ` Dominik Csapak
2023-11-08 12:38 ` Thomas Lamprecht
2023-11-08 13:26 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231030125811.11759-2-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox