[pve-devel] [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`

[pve-devel] [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`

[Stefan Sterz]

some icons intentionally use black as their color in the light theme.
this includes the little pencil and check mark icon in the acme
overview. change their color to the regular dark-mode icon-color. for
this to work the filter inversion needed for some other icons needs to
be remove too.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 src/proxmox-dark/scss/other/_icons.scss | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
index d4dc316..c045cf4 100644
--- a/src/proxmox-dark/scss/other/_icons.scss
+++ b/src/proxmox-dark/scss/other/_icons.scss
@@ -104,6 +104,9 @@
 }

 // pbs show task log in longest task list column
+.fa.black,
+.fa.black::after,
+.fa.black::before,
 .x-action-col-icon.fa-chevron-right::before {
   filter: none;
 }
@@ -222,6 +225,12 @@
   }
 }

+// set icon color of intentional black icons (e.g.: pencil icon for
+// quickly changing the ACME account)
+.fa.black {
+  color: $icon-color;
+}
+
 // The usage icons dynamically displaying how full a storage is
 .usage-wrapper {
   border: 1px solid $icon-color;
--
2.39.2

Re: [pve-devel] [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`

[Stefan Sterz]

On Mon Oct 16, 2023 at 6:28 PM CEST, Stefan Sterz wrote:
> some icons intentionally use black as their color in the light theme.
> this includes the little pencil and check mark icon in the acme
> overview. change their color to the regular dark-mode icon-color. for
> this to work the filter inversion needed for some other icons needs to
> be remove too.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  src/proxmox-dark/scss/other/_icons.scss | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/src/proxmox-dark/scss/other/_icons.scss b/src/proxmox-dark/scss/other/_icons.scss
> index d4dc316..c045cf4 100644
> --- a/src/proxmox-dark/scss/other/_icons.scss
> +++ b/src/proxmox-dark/scss/other/_icons.scss
> @@ -104,6 +104,9 @@
>  }
>
>  // pbs show task log in longest task list column
> +.fa.black,
> +.fa.black::after,
> +.fa.black::before,
>  .x-action-col-icon.fa-chevron-right::before {
>    filter: none;
>  }
> @@ -222,6 +225,12 @@
>    }
>  }
>
> +// set icon color of intentional black icons (e.g.: pencil icon for
> +// quickly changing the ACME account)
> +.fa.black {
> +  color: $icon-color;
> +}
> +
>  // The usage icons dynamically displaying how full a storage is
>  .usage-wrapper {
>    border: 1px solid $icon-color;
> --
> 2.39.2

ping, this still applies for me :)

[pve-devel] applied: [PATCH widget-toolkit] dark-mode: set intentionally black icons to `$icon-color`

[Thomas Lamprecht]

Am 16/10/2023 um 18:28 schrieb Stefan Sterz:
> some icons intentionally use black as their color in the light theme.
> this includes the little pencil and check mark icon in the acme
> overview. change their color to the regular dark-mode icon-color. for
> this to work the filter inversion needed for some other icons needs to
> be remove too.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  src/proxmox-dark/scss/other/_icons.scss | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
>

applied, thanks!