public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] Correct DNS IP check on management interface setup
@ 2023-10-16 10:20 Filip Schauer
  2023-11-06 16:40 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Filip Schauer @ 2023-10-16 10:20 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 proxinstall | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxinstall b/proxinstall
index d5b2565..764187f 100755
--- a/proxinstall
+++ b/proxinstall
@@ -481,8 +481,8 @@ sub create_ipconf_view {
 	$text = $ipconf_entry_dns->get_text();
 	my ($dns_ip, $dns_ip_version) = parse_ip_address($text);
 	if (!defined($dns_ip) || $dns_ip_version != $ipversion) {
-	    my $msg = defined($gateway_ip)
-	        ? "DNS and host IP version must not differ (IPv$gateway_ip_version != IPv$ipversion)."
+	    my $msg = defined($dns_ip)
+	        ? "DNS and host IP version must not differ (IPv$dns_ip_version != IPv$ipversion)."
 	        : "DNS IP is not valid.";
 	    Proxmox::UI::message($msg);
 	    $ipconf_entry_dns->grab_focus();
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH installer] Correct DNS IP check on management interface setup
  2023-10-16 10:20 [pve-devel] [PATCH installer] Correct DNS IP check on management interface setup Filip Schauer
@ 2023-11-06 16:40 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-06 16:40 UTC (permalink / raw)
  To: Proxmox VE development discussion, Filip Schauer

Am 16/10/2023 um 12:20 schrieb Filip Schauer:
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>  proxinstall | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-06 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-16 10:20 [pve-devel] [PATCH installer] Correct DNS IP check on management interface setup Filip Schauer
2023-11-06 16:40 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal