[pve-devel] [PATCH manager v3] ui: DirEdit: LVMEdit: add hint when to enable shared

[pve-devel] [PATCH manager v3] ui: DirEdit: LVMEdit: add hint when to enable shared

[Aaron Lauterer]

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
---
changes since v2: fixed missing trailing comma

 www/manager6/storage/DirEdit.js | 4 ++++
 www/manager6/storage/LVMEdit.js | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 7e9ec44d..3e2025fc 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
 		name: 'shared',
 		uncheckedValue: 0,
 		fieldLabel: gettext('Shared'),
+		autoEl: {
+		    tag: 'div',
+		    'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
+		},
 	    },
 	];
 
diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index 75c7bdb8..75af6bf7 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
 	    name: 'shared',
 	    uncheckedValue: 0,
 	    fieldLabel: gettext('Shared'),
+	    autoEl: {
+		tag: 'div',
+		'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
+	    },
 	},
     ],
 });
-- 
2.39.2

[pve-devel] applied: [PATCH manager v3] ui: DirEdit: LVMEdit: add hint when to enable shared

[Fabian Grünbichler]

thanks!

On October 10, 2023 3:24 pm, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> changes since v2: fixed missing trailing comma
> 
>  www/manager6/storage/DirEdit.js | 4 ++++
>  www/manager6/storage/LVMEdit.js | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> index 7e9ec44d..3e2025fc 100644
> --- a/www/manager6/storage/DirEdit.js
> +++ b/www/manager6/storage/DirEdit.js
> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>  		name: 'shared',
>  		uncheckedValue: 0,
>  		fieldLabel: gettext('Shared'),
> +		autoEl: {
> +		    tag: 'div',
> +		    'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
> +		},
>  	    },
>  	];
>  
> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
> index 75c7bdb8..75af6bf7 100644
> --- a/www/manager6/storage/LVMEdit.js
> +++ b/www/manager6/storage/LVMEdit.js
> @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
>  	    name: 'shared',
>  	    uncheckedValue: 0,
>  	    fieldLabel: gettext('Shared'),
> +	    autoEl: {
> +		tag: 'div',
> +		'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
> +	    },
>  	},
>      ],
>  });
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
>