[pve-devel] [PATCH proxmox-i18n 0/1] update German translation

[pve-devel] [PATCH proxmox-i18n 0/1] update German translation

[hd]

I suggest an update of the german translation

hd (1):
  update German translation

 de.po | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.39.2

[pve-devel] [PATCH proxmox-i18n 1/1] update German translation

[hd]

---
 de.po | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/de.po b/de.po
index fea74f1..c647f31 100644
--- a/de.po
+++ b/de.po
@@ -747,9 +747,8 @@ msgid "Authentication mode"
 msgstr "Authentifikationsmodus"
 
 #: proxmox-widget-toolkit/src/panel/SendmailEditPanel.js:111
-#, fuzzy
 msgid "Author"
-msgstr "Auth-ID"
+msgstr "Autor"
 
 #: pmg-gui/js/TFAView.js:60 pve-manager/www/manager6/dc/OptionView.js:241
 #: proxmox-backup/www/config/WebauthnView.js:109
-- 
2.39.2

Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation

[Lukas Wagner]

Hello Hannes,

please configure your git client so that the commit author is your full 
name [1]:

   git config --global user.name "Firstname Lastname"

Also, this patch is missing the 'Signed-off-by' line. That line is 
auto-generated by git if you provide the right flags to `git commit` or 
`git format-patch` (e.g. `git commit -s`, maybe create a git alias for that)

Also, for single patches there is no need to send a cover-letter.
If there is anything to be said about the patch that should *not* be
part of the commit message, you can write it under the the '---' marker.

Hope this helps :)

[1] https://pve.proxmox.com/wiki/Developer_Documentation#Using_git

On 10/9/23 11:38, hd wrote:
> ---
     ^ I mean this marker here.

>   de.po | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/de.po b/de.po
> index fea74f1..c647f31 100644
> --- a/de.po
> +++ b/de.po
> @@ -747,9 +747,8 @@ msgid "Authentication mode"
>   msgstr "Authentifikationsmodus"
>   
>   #: proxmox-widget-toolkit/src/panel/SendmailEditPanel.js:111
> -#, fuzzy
>   msgid "Author"
> -msgstr "Auth-ID"
> +msgstr "Autor"
>   
>   #: pmg-gui/js/TFAView.js:60 pve-manager/www/manager6/dc/OptionView.js:241
>   #: proxmox-backup/www/config/WebauthnView.js:109

-- 
- Lukas

Re: [pve-devel] [PATCH proxmox-i18n 1/1] update German translation

[Thomas Lamprecht]

Am 09/10/2023 um 11:38 schrieb hd:
> ---
>  de.po | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

On-top of what Lukas mentioned: there are dozens of fuzzy strings
in de.po, and applying/reviewing patches has a slight overhead
independent of the amount of changes, so I'd be great if you send
an update for a few more than just a single change in one patch,
so we get a better "return of (review/apply time) investment".