public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 qemu 2/9] buildsys: fixup submodule target
Date: Fri,  6 Oct 2023 13:01:41 +0200	[thread overview]
Message-ID: <20231006110148.154914-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20231006110148.154914-1-f.ebner@proxmox.com>

It's not enough to initialize the submodules anymore, as some got
replaced by wrap files, see QEMU commit 2019cabfee ("meson:
subprojects: replace submodules with wrap files").

Download the subprojects during initialization of the QEMU submodule,
so building (without the automagical --enable-download) can succeeed
afterwards.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

No changes in v2.

 Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 6c62c78..e389a9c 100644
--- a/Makefile
+++ b/Makefile
@@ -17,7 +17,10 @@ all: $(DEBS)
 
 .PHONY: submodule
 submodule:
-	test -f "$(SRCDIR)/configure" || git submodule update --init --recursive
+ifeq ($(shell test -f "$(SRCDIR)/configure" && echo 1 || echo 0), 0)
+	git submodule update --init --recursive
+	cd $(SRCDIR); meson subprojects download
+endif
 
 PC_BIOS_FW_PURGE_LIST_IN = \
 	hppa-firmware.img \
-- 
2.39.2





  parent reply	other threads:[~2023-10-06 11:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06 11:01 [pve-devel] [PATCH-SERIES v2 qemu] update to QEMU 8.1.1 Fiona Ebner
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 1/9] d/rules: use disable-download option instead of git-submodules=ignore Fiona Ebner
2023-10-06 11:01 ` Fiona Ebner [this message]
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 3/9] buildsys: use QEMU's keycodemapdb again Fiona Ebner
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 4/9] update submodule and patches to QEMU 8.1.1 Fiona Ebner
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 5/9] add patch to disable graph locking Fiona Ebner
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 6/9] add patch to avoid huge snapshot performance regression Fiona Ebner
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 7/9] d/control: add versioned Breaks for qemu-server <= 8.0.6 Fiona Ebner
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 8/9] cherry-pick stable fixes to avoid crash in IO error scenarios Fiona Ebner
2023-10-06 11:01 ` [pve-devel] [PATCH v2 qemu 9/9] add stable fix to avoid crash in SCSI when guest uses too small blocksize Fiona Ebner
2023-10-17 12:11 ` [pve-devel] [PATCH-SERIES v2 qemu] update to QEMU 8.1.1 Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006110148.154914-3-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal