From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/3] tui: remove global, unsafe setup info
Date: Wed, 4 Oct 2023 18:00:54 +0200 [thread overview]
Message-ID: <20231004160325.704249-1-c.heiss@proxmox.com> (raw)
Removes the `static mut` for holding a `SetupInfo` instance.
This is done by either passing the needed info as parameter, or in some
cases, the needed information is already available through other means.
Not only does it get rid of some ugly, unsafe code, it is needed anyway
as a prerequisite by Aaron for pulling out non-TUI-related code into a
separate, shared crate.
No functional changes overall.
Christoph Heiss (3):
tui: refactor `NetworkOptions` to have a `defaults_from()` function
tui: bootdisk: pass down product info to advanced dialog
tui: remove obsolete, global `SetupInfo` state
proxmox-tui-installer/src/main.rs | 34 +++-------
proxmox-tui-installer/src/options.rs | 36 ++++------
proxmox-tui-installer/src/setup.rs | 10 ++-
proxmox-tui-installer/src/views/bootdisk.rs | 74 ++++++++++++++-------
4 files changed, 74 insertions(+), 80 deletions(-)
--
2.41.0
next reply other threads:[~2023-10-04 16:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 16:00 Christoph Heiss [this message]
2023-10-04 16:00 ` [pve-devel] [PATCH installer 1/3] tui: refactor `NetworkOptions` to have a `defaults_from()` function Christoph Heiss
2023-10-04 16:00 ` [pve-devel] [PATCH installer 2/3] tui: bootdisk: pass down product info to advanced dialog Christoph Heiss
2023-10-04 16:00 ` [pve-devel] [PATCH installer 3/3] tui: remove obsolete, global `SetupInfo` state Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004160325.704249-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox