From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-network 1/3] zones: add|del_bridge_fdb : remove firewall param
Date: Tue, 26 Sep 2023 09:39:40 +0200 [thread overview]
Message-ID: <20230926073942.3212260-4-aderumier@odiso.com> (raw)
In-Reply-To: <20230926073942.3212260-1-aderumier@odiso.com>
It's not used anymore in Network.pm
---
src/PVE/Network/SDN/Zones.pm | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/PVE/Network/SDN/Zones.pm b/src/PVE/Network/SDN/Zones.pm
index 7d70e49..1e678ed 100644
--- a/src/PVE/Network/SDN/Zones.pm
+++ b/src/PVE/Network/SDN/Zones.pm
@@ -326,31 +326,31 @@ sub tap_plug {
}
sub add_bridge_fdb {
- my ($iface, $macaddr, $bridge, $firewall) = @_;
+ my ($iface, $macaddr, $bridge) = @_;
my $vnet = PVE::Network::SDN::Vnets::get_vnet($bridge, 1);
if (!$vnet) { # fallback for classic bridge
- PVE::Network::add_bridge_fdb($iface, $macaddr, $firewall);
+ PVE::Network::add_bridge_fdb($iface, $macaddr);
return;
}
my $plugin_config = get_plugin_config($vnet);
my $plugin = PVE::Network::SDN::Zones::Plugin->lookup($plugin_config->{type});
- PVE::Network::add_bridge_fdb($iface, $macaddr, $firewall) if $plugin_config->{'bridge-disable-mac-learning'};
+ PVE::Network::add_bridge_fdb($iface, $macaddr) if $plugin_config->{'bridge-disable-mac-learning'};
}
sub del_bridge_fdb {
- my ($iface, $macaddr, $bridge, $firewall) = @_;
+ my ($iface, $macaddr, $bridge) = @_;
my $vnet = PVE::Network::SDN::Vnets::get_vnet($bridge, 1);
if (!$vnet) { # fallback for classic bridge
- PVE::Network::del_bridge_fdb($iface, $macaddr, $firewall);
+ PVE::Network::del_bridge_fdb($iface, $macaddr);
return;
}
my $plugin_config = get_plugin_config($vnet);
my $plugin = PVE::Network::SDN::Zones::Plugin->lookup($plugin_config->{type});
- PVE::Network::del_bridge_fdb($iface, $macaddr, $firewall) if $plugin_config->{'bridge-disable-mac-learning'};
+ PVE::Network::del_bridge_fdb($iface, $macaddr) if $plugin_config->{'bridge-disable-mac-learning'};
}
1;
--
2.39.2
next prev parent reply other threads:[~2023-09-26 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 7:39 [pve-devel] [PATCH-SERIES pve-network/qemu-server/pve-container] cleanup for static mac registration Alexandre Derumier
2023-09-26 7:39 ` [pve-devel] [PATCH pve-container 1/1] add_bridge_fbd: remove unused firewall param Alexandre Derumier
2023-09-26 7:39 ` [pve-devel] [PATCH qemu-server 1/1] add|del_bridge_fdb: " Alexandre Derumier
2023-09-26 7:39 ` Alexandre Derumier [this message]
2023-09-26 7:39 ` [pve-devel] [PATCH pve-network 2/3] zones: add add|del_bridge_fdb to plugins Alexandre Derumier
2023-09-26 7:39 ` [pve-devel] [PATCH pve-network 3/3] zones: evpn: add disable-bridge-learning Alexandre Derumier
2023-10-25 11:22 ` [pve-devel] applied-series: [PATCH-SERIES pve-network/qemu-server/pve-container] cleanup for static mac registration Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926073942.3212260-4-aderumier@odiso.com \
--to=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox