public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common v2] fix #4162: added `Auto-Submitted` header to email body
Date: Tue, 19 Sep 2023 09:35:25 +0200	[thread overview]
Message-ID: <20230919073525.9163-1-g.goller@proxmox.com> (raw)

`Auto-Submitted` is defined in the rfc 5436 [1] and describes how
an automatic response (f.e. ooo replies, etc.) should behave on the
emails. When using `Auto-Submitted: auto-generated` (or any value
other than `none`) automatic replies won't be triggered.

[1]: https://www.rfc-editor.org/rfc/rfc3834.html

Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
---

Note: this is already merged in `proxmox_sys::mail::sendmail`,
      which is used by pbs and pve. This is aimed at pmg, which
      still uses the perl implementation and for keeping the email
      behavior consistent through all products.

 src/PVE/Tools.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm
index 569f0cd..c91e933 100644
--- a/src/PVE/Tools.pm
+++ b/src/PVE/Tools.pm
@@ -1598,6 +1598,7 @@ sub sendmail {
 
     if (defined($text)) {
 	print $mail "Content-Type: text/plain;\n";
+	print $mail "Auto-Submitted: auto-generated;\n";
 	print $mail "\tcharset=\"UTF-8\"\n";
 	print $mail "Content-Transfer-Encoding: 8bit\n";
 	print $mail "\n";
@@ -1613,6 +1614,7 @@ sub sendmail {
 
     if (defined($html)) {
 	print $mail "Content-Type: text/html;\n";
+	print $mail "Auto-Submitted: auto-generated;\n";
 	print $mail "\tcharset=\"UTF-8\"\n";
 	print $mail "Content-Transfer-Encoding: 8bit\n";
 	print $mail "\n";
-- 
2.39.2





             reply	other threads:[~2023-09-19  7:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  7:35 Gabriel Goller [this message]
2023-11-06 17:40 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230919073525.9163-1-g.goller@proxmox.com \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal