[pve-devel] [PATCH manager] ui: notification: remove unneeded gettext calls

[pve-devel] [PATCH manager] ui: notification: remove unneeded gettext calls

[Lukas Wagner]

'mail-to-root' is the name of the default notification target and
should thus not be translated.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/manager6/dc/NotificationEvents.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/dc/NotificationEvents.js b/www/manager6/dc/NotificationEvents.js
index 21628204..18816290 100644
--- a/www/manager6/dc/NotificationEvents.js
+++ b/www/manager6/dc/NotificationEvents.js
@@ -40,7 +40,7 @@ Ext.define('PVE.dc.NotificationEventsTargetSelector', {
     editable: true,
     autoSelect: false,
     deleteEmpty: false,
-    emptyText: `${Proxmox.Utils.defaultText} (${gettext("mail-to-root")})`,
+    emptyText: `${Proxmox.Utils.defaultText} (mail-to-root)`,
 });
 
 Ext.define('PVE.dc.NotificationEvents', {
@@ -126,7 +126,7 @@ Ext.define('PVE.dc.NotificationEvents', {
 	// Needed since the actual value is always stored in the 'notify' property
 	let render_value = (store, target_key, mode_key, default_val) => {
 	    let value = store.getById('notify')?.get('value') ?? {};
-	    let target = value[target_key] ?? gettext('mail-to-root');
+	    let target = value[target_key] ?? 'mail-to-root';
 	    let template;
 
 	    switch (value[mode_key]) {
-- 
2.39.2

[pve-devel] applied: [PATCH manager] ui: notification: remove unneeded gettext calls

[Thomas Lamprecht]

Am 18/09/2023 um 10:20 schrieb Lukas Wagner:
> 'mail-to-root' is the name of the default notification target and
> should thus not be translated.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  www/manager6/dc/NotificationEvents.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!