From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: notification: remove unneeded gettext calls
Date: Mon, 18 Sep 2023 10:20:26 +0200 [thread overview]
Message-ID: <20230918082026.160163-1-l.wagner@proxmox.com> (raw)
'mail-to-root' is the name of the default notification target and
should thus not be translated.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/NotificationEvents.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/dc/NotificationEvents.js b/www/manager6/dc/NotificationEvents.js
index 21628204..18816290 100644
--- a/www/manager6/dc/NotificationEvents.js
+++ b/www/manager6/dc/NotificationEvents.js
@@ -40,7 +40,7 @@ Ext.define('PVE.dc.NotificationEventsTargetSelector', {
editable: true,
autoSelect: false,
deleteEmpty: false,
- emptyText: `${Proxmox.Utils.defaultText} (${gettext("mail-to-root")})`,
+ emptyText: `${Proxmox.Utils.defaultText} (mail-to-root)`,
});
Ext.define('PVE.dc.NotificationEvents', {
@@ -126,7 +126,7 @@ Ext.define('PVE.dc.NotificationEvents', {
// Needed since the actual value is always stored in the 'notify' property
let render_value = (store, target_key, mode_key, default_val) => {
let value = store.getById('notify')?.get('value') ?? {};
- let target = value[target_key] ?? gettext('mail-to-root');
+ let target = value[target_key] ?? 'mail-to-root';
let template;
switch (value[mode_key]) {
--
2.39.2
next reply other threads:[~2023-09-18 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 8:20 Lukas Wagner [this message]
2023-09-18 10:07 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918082026.160163-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox