[pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages

[pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages

[Fiona Ebner]

The one with the backup flag was reported in the community forum:
https://forum.proxmox.com/threads/77254/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Changes in v2:
    * Further improve message as suggested by Sterzy.

 pve-zsync | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pve-zsync b/pve-zsync
index 98190b2..de5d46f 100755
--- a/pve-zsync
+++ b/pve-zsync
@@ -949,11 +949,12 @@ sub parse_disks {
 	    $num++;
 
 	} else {
-	    die "ERROR: in path\n";
+	    die "unexpected path '$path'\n";
 	}
     }
 
-    die "Vm include no disk on zfs.\n" if !$disks->{0};
+    die "Guest does not include any ZFS volumes (or all are excluded by the backup flag).\n"
+	if !$disks->{0};
     return $disks;
 }
 
-- 
2.39.2

Re: [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages

[Fiona Ebner]

Am 12.09.23 um 14:29 schrieb Fiona Ebner:
> The one with the backup flag was reported in the community forum:
> https://forum.proxmox.com/threads/77254/
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>

Ping

[pve-devel] applied: [PATCH v2 pve-zsync] parse disks: improve error messages

[Thomas Lamprecht]

On 12/09/2023 14:29, Fiona Ebner wrote:
> The one with the backup flag was reported in the community forum:
> https://forum.proxmox.com/threads/77254/
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes in v2:
>     * Further improve message as suggested by Sterzy.
> 
>  pve-zsync | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

should this immediately bumped or is there some other patches, existing
or short-term planned? Just not that we forget this for too long now
(FWIW, feel free to do the bump yourself if you want).

Re: [pve-devel] applied: [PATCH v2 pve-zsync] parse disks: improve error messages

[Fiona Ebner]

Am 11.04.24 um 21:04 schrieb Thomas Lamprecht:
> On 12/09/2023 14:29, Fiona Ebner wrote:
>> The one with the backup flag was reported in the community forum:
>> https://forum.proxmox.com/threads/77254/
>>
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Changes in v2:
>>     * Further improve message as suggested by Sterzy.
>>
>>  pve-zsync | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>>
> 
> applied, thanks!
> 
> should this immediately bumped or is there some other patches, existing
> or short-term planned? Just not that we forget this for too long now
> (FWIW, feel free to do the bump yourself if you want).

I'm not aware of any outstanding patches. Okay, I'll go ahead and bump it.