From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 pve-zsync] parse disks: improve error messages
Date: Tue, 12 Sep 2023 14:29:54 +0200 [thread overview]
Message-ID: <20230912122954.156735-1-f.ebner@proxmox.com> (raw)
The one with the backup flag was reported in the community forum:
https://forum.proxmox.com/threads/77254/
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Changes in v2:
* Further improve message as suggested by Sterzy.
pve-zsync | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/pve-zsync b/pve-zsync
index 98190b2..de5d46f 100755
--- a/pve-zsync
+++ b/pve-zsync
@@ -949,11 +949,12 @@ sub parse_disks {
$num++;
} else {
- die "ERROR: in path\n";
+ die "unexpected path '$path'\n";
}
}
- die "Vm include no disk on zfs.\n" if !$disks->{0};
+ die "Guest does not include any ZFS volumes (or all are excluded by the backup flag).\n"
+ if !$disks->{0};
return $disks;
}
--
2.39.2
next reply other threads:[~2023-09-12 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 12:29 Fiona Ebner [this message]
2024-04-11 11:57 ` Fiona Ebner
2024-04-11 19:04 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-12 7:07 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912122954.156735-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox