From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ceph: api: use snake_case when setting options
Date: Thu, 7 Sep 2023 11:49:42 +0200 [thread overview]
Message-ID: <20230907094942.74479-2-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20230907094942.74479-1-m.sandoval@proxmox.com>
Continuation of ab70343982f36a5343d3fcf4a1a6489bd3f52a66. Discussion at
https://lists.proxmox.com/pipermail/pve-devel/2023-September/059013.html.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
PVE/API2/Ceph.pm | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
index a4101dee..afc9b9e2 100644
--- a/PVE/API2/Ceph.pm
+++ b/PVE/API2/Ceph.pm
@@ -197,12 +197,12 @@ __PACKAGE__->register_method ({
$cfg->{global} = {
'fsid' => $fsid,
- 'auth cluster required' => $auth,
- 'auth service required' => $auth,
- 'auth client required' => $auth,
- 'osd pool default size' => $param->{size} // 3,
- 'osd pool default min size' => $param->{min_size} // 2,
- 'mon allow pool delete' => 'true',
+ 'auth_cluster_required' => $auth,
+ 'auth_service_required' => $auth,
+ 'auth_client_required' => $auth,
+ 'osd_pool_default_size' => $param->{size} // 3,
+ 'osd_pool_default_min_size' => $param->{min_size} // 2,
+ 'mon_allow_pool_delete' => 'true',
};
# this does not work for default pools
@@ -215,12 +215,12 @@ __PACKAGE__->register_method ({
}
if ($param->{network}) {
- $cfg->{global}->{'public network'} = $param->{network};
- $cfg->{global}->{'cluster network'} = $param->{network};
+ $cfg->{global}->{'public_network'} = $param->{network};
+ $cfg->{global}->{'cluster_network'} = $param->{network};
}
if ($param->{'cluster-network'}) {
- $cfg->{global}->{'cluster network'} = $param->{'cluster-network'};
+ $cfg->{global}->{'cluster_network'} = $param->{'cluster-network'};
}
cfs_write_file('ceph.conf', $cfg);
--
2.39.2
next prev parent reply other threads:[~2023-09-07 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 9:49 [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting Maximiliano Sandoval
2023-09-07 9:49 ` Maximiliano Sandoval [this message]
2023-09-20 12:10 ` Dominik Csapak
2023-09-20 13:21 ` Thomas Lamprecht
2023-09-20 13:42 ` Maximiliano Sandoval
2023-09-20 14:27 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230907094942.74479-2-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox