From: Markus Frank <m.frank@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v1] fix #4947 spice: correct filename extension safari
Date: Wed, 6 Sep 2023 11:37:03 +0200 [thread overview]
Message-ID: <20230906093703.64864-1-m.frank@proxmox.com> (raw)
Fix file extension for SPICE config download on
AppleWebKit browsers to ensure proper application
association on MacOS.
Signed-off-by: Markus Frank <m.frank@proxmox.com>
---
www/manager6/Utils.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 6d4842df..06b63315 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1401,10 +1401,11 @@ Ext.define('PVE.Utils', {
css: 'display:none;visibility:hidden;height:0px;',
});
- // Note: we need to tell Android and Chrome the correct file name extension
+ // Note: we need to tell Android, AppleWebKit and Chrome
+ // the correct file name extension
// but we do not set 'download' tag for other environments, because
// It can have strange side effects (additional user prompt on firefox)
- if (navigator.userAgent.match(/Android|Chrome/i)) {
+ if (navigator.userAgent.match(/Android|AppleWebKit|Chrome/i)) {
link.download = name;
}
--
2.39.2
next reply other threads:[~2023-09-06 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 9:37 Markus Frank [this message]
2023-09-06 14:47 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230906093703.64864-1-m.frank@proxmox.com \
--to=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox