From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #4808: ceph: use setting names with underscores
Date: Tue, 5 Sep 2023 10:53:31 +0200 [thread overview]
Message-ID: <20230905085331.541541-1-m.sandoval@proxmox.com> (raw)
As suggested in [1], it is recommended to use `_` in all cases when
dealing with config files.
[1] https://docs.ceph.com/en/reef/rados/configuration/ceph-conf/#option-names
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
PVE/API2/Ceph/MDS.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/Ceph/MDS.pm b/PVE/API2/Ceph/MDS.pm
index 1cb0b74f..6fc0ae45 100644
--- a/PVE/API2/Ceph/MDS.pm
+++ b/PVE/API2/Ceph/MDS.pm
@@ -153,10 +153,10 @@ __PACKAGE__->register_method ({
}
$cfg->{$section}->{host} = $nodename;
- $cfg->{$section}->{"mds standby for name"} = 'pve';
+ $cfg->{$section}->{'mds_standby_for_name'} = 'pve';
if ($param->{hotstandby}) {
- $cfg->{$section}->{"mds standby replay"} = 'true';
+ $cfg->{$section}->{'mds_standby_replay'} = 'true';
}
cfs_write_file('ceph.conf', $cfg);
--
2.39.2
next reply other threads:[~2023-09-05 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 8:53 Maximiliano Sandoval [this message]
2023-09-06 14:57 ` [pve-devel] applied: " Thomas Lamprecht
2023-09-07 9:07 ` Maximiliano Sandoval
2023-09-07 9:30 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230905085331.541541-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox