From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container] fix #4846: Avoid the outdated noacl mount option on ext4
Date: Fri, 1 Sep 2023 11:05:53 +0200 [thread overview]
Message-ID: <20230901090553.17817-1-f.schauer@proxmox.com> (raw)
Do not use the 'noacl' mount option when mounting a container disk with
an ext4 file system. The option was removed from the kernel in commit
2d544ec923db
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
src/PVE/LXC.pm | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 1e9af0f..3ebce37 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1764,9 +1764,6 @@ sub __mountpoint_mount {
}
my $acl = $mountpoint->{acl};
- if (defined($acl)) {
- push @$optlist, ($acl ? 'acl' : 'noacl');
- }
my $optstring = join(',', @$optlist);
my $readonly = $mountpoint->{ro};
@@ -1787,6 +1784,13 @@ sub __mountpoint_mount {
$format = 'iso' if $vtype eq 'iso'; # allow to handle iso files
+ # Avoid the outdated 'noacl' mount option on ext4 file systems
+ if ($scfg->{type} ne 'zfspool') {
+ push @$optlist, 'acl' if $acl;
+ } elsif (defined($acl)) {
+ push @$optlist, ($acl ? 'acl' : 'noacl');
+ }
+
if ($format eq 'subvol') {
if ($mount_path) {
my (undef, $name) = PVE::Storage::parse_volname($storage_cfg, $volid);
--
2.39.2
next reply other threads:[~2023-09-01 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 9:05 Filip Schauer [this message]
2024-02-14 13:57 ` Filip Schauer
2024-02-16 13:59 ` Fiona Ebner
2024-02-23 10:50 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230901090553.17817-1-f.schauer@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox