From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common/cluster 0/3] fix #4937: fix utf8 encoding issues while saving notification config
Date: Wed, 30 Aug 2023 14:37:51 +0200 [thread overview]
Message-ID: <20230830123754.606260-1-l.wagner@proxmox.com> (raw)
These patches should fix issues with certain special characters
(e.g ü) in the notification configuration [1].
Before, when setting a comment for an endpoint to certain values
(e.g. 'für admins'), the resulting saved configuration would
contain invalid UTF8 text.
The reason for that was the configuration was returned from
Rust as a proper utf8 string, however it was saved to the file
system without specifying an encoding.
[1] https://bugzilla.proxmox.com/show_bug.cgi?id=4937
pve-common:
Lukas Wagner (1):
tools: allow to specify file encoding for file_set_contents
src/PVE/Tools.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
pve-cluster:
Lukas Wagner (2):
cluster fs: allow to specify file encoding for cfs_write_file
fix #4937: notify: write configuration files in utf8 encoding
src/PVE/Cluster.pm | 4 ++--
src/PVE/Notify.pm | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Summary over all repositories:
3 files changed, 10 insertions(+), 5 deletions(-)
--
murpp v0.4.0
next reply other threads:[~2023-08-30 12:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 12:37 Lukas Wagner [this message]
2023-08-30 12:37 ` [pve-devel] [PATCH pve-common 1/3] tools: allow to specify file encoding for file_set_contents Lukas Wagner
2023-08-30 12:37 ` [pve-devel] [PATCH pve-cluster 2/3] cluster fs: allow to specify file encoding for cfs_write_file Lukas Wagner
2023-08-30 12:37 ` [pve-devel] [PATCH pve-cluster 3/3] fix #4937: notify: write configuration files in utf8 encoding Lukas Wagner
2023-09-01 7:40 ` [pve-devel] [PATCH common/cluster 0/3] fix #4937: fix utf8 encoding issues while saving notification config Lukas Wagner
2023-09-11 12:50 ` [pve-devel] applied-series: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830123754.606260-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox