From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2] fix #4634: ui: osd: allow to translate the entire string
Date: Mon, 28 Aug 2023 17:54:59 +0200 [thread overview]
Message-ID: <20230828155459.245761-1-m.sandoval@proxmox.com> (raw)
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
xgettext supports extracting comments so I added a comment to make it future
proof. Note though our tooling (proxmox-i18n) strips them. I hope to send a patch fixing
this soon.
Differences from v1:
- Use format instead of relying on a translator comment.
www/manager6/ceph/OSD.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index d2caafa4..242674fb 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -233,7 +233,8 @@ Ext.define('PVE.CephSetFlags', {
onlineHelp: 'pve_ceph_osds',
isCreate: true,
- title: Ext.String.format(gettext('Manage {0}'), 'Global OSD Flags'),
+ // TRANSLATORS: This will read 'Manage Global OSD Flags'.
+ title: Ext.String.format(gettext('Manage Global {0} Flags'), 'OSD'),
submitText: gettext('Apply'),
items: [
@@ -837,7 +838,7 @@ Ext.define('PVE.node.CephOsdTree', {
handler: 'create_osd',
},
{
- text: Ext.String.format(gettext('Manage {0}'), 'Global Flags'),
+ text: gettext('Manage Global Flags'),
handler: 'set_flags',
},
'->',
--
2.39.2
next reply other threads:[~2023-08-28 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 15:54 Maximiliano Sandoval [this message]
2023-09-04 16:26 ` Thomas Lamprecht
[not found] ` <06fd86b4-0bf0-4dcf-a611-8ed936f4b1a2@proxmox.com>
2023-09-05 6:37 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828155459.245761-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox