From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] notify ui: fix `gettext` calls
Date: Mon, 28 Aug 2023 14:58:34 +0200 [thread overview]
Message-ID: <20230828125834.496905-1-l.wagner@proxmox.com> (raw)
gettext is rather dumb and does not like multi-line strings or string
interpolation.
Also removed some unneeded gettext calls (mail-to-root should not be
translated.)
Reported-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
www/manager6/dc/NotificationEvents.js | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/www/manager6/dc/NotificationEvents.js b/www/manager6/dc/NotificationEvents.js
index f2ee12e0..18816290 100644
--- a/www/manager6/dc/NotificationEvents.js
+++ b/www/manager6/dc/NotificationEvents.js
@@ -29,8 +29,7 @@ Ext.define('PVE.dc.NotificationEventDisabledWarning', {
extend: 'Ext.form.field.Display',
userCls: 'pmx-hint',
hidden: true,
- value: gettext('Disabling notifications is not ' +
- 'recommended for production systems!'),
+ value: gettext('Disabling notifications is not recommended for production systems!'),
});
Ext.define('PVE.dc.NotificationEventsTargetSelector', {
@@ -41,7 +40,7 @@ Ext.define('PVE.dc.NotificationEventsTargetSelector', {
editable: true,
autoSelect: false,
deleteEmpty: false,
- emptyText: `${Proxmox.Utils.defaultText} (${gettext("mail-to-root")})`,
+ emptyText: `${Proxmox.Utils.defaultText} (mail-to-root)`,
});
Ext.define('PVE.dc.NotificationEvents', {
@@ -127,7 +126,7 @@ Ext.define('PVE.dc.NotificationEvents', {
// Needed since the actual value is always stored in the 'notify' property
let render_value = (store, target_key, mode_key, default_val) => {
let value = store.getById('notify')?.get('value') ?? {};
- let target = value[target_key] ?? gettext('mail-to-root');
+ let target = value[target_key] ?? 'mail-to-root';
let template;
switch (value[mode_key]) {
--
2.39.2
reply other threads:[~2023-08-28 12:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828125834.496905-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox