public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] fix #4634: ui: osd: allow to translate the entire string
@ 2023-08-28 11:10 Maximiliano Sandoval
  2023-08-28 11:26 ` Fiona Ebner
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2023-08-28 11:10 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/ceph/OSD.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index d2caafa4..eda60f2f 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -233,7 +233,8 @@ Ext.define('PVE.CephSetFlags', {
 
     onlineHelp: 'pve_ceph_osds',
     isCreate: true,
-    title: Ext.String.format(gettext('Manage {0}'), 'Global OSD Flags'),
+    // TRANSLATORS: Do not translate OSD.
+    title: gettext('Manage Global OSD Flags'),
     submitText: gettext('Apply'),
 
     items: [
@@ -837,7 +838,7 @@ Ext.define('PVE.node.CephOsdTree', {
 		handler: 'create_osd',
 	    },
 	    {
-		text: Ext.String.format(gettext('Manage {0}'), 'Global Flags'),
+		text: gettext('Manage Global Flags'),
 		handler: 'set_flags',
 	    },
 	    '->',
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH manager] fix #4634: ui: osd: allow to translate the entire string
  2023-08-28 11:10 [pve-devel] [PATCH manager] fix #4634: ui: osd: allow to translate the entire string Maximiliano Sandoval
@ 2023-08-28 11:26 ` Fiona Ebner
  0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2023-08-28 11:26 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 28.08.23 um 13:10 schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  www/manager6/ceph/OSD.js | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
> index d2caafa4..eda60f2f 100644
> --- a/www/manager6/ceph/OSD.js
> +++ b/www/manager6/ceph/OSD.js
> @@ -233,7 +233,8 @@ Ext.define('PVE.CephSetFlags', {
>  
>      onlineHelp: 'pve_ceph_osds',
>      isCreate: true,
> -    title: Ext.String.format(gettext('Manage {0}'), 'Global OSD Flags'),
> +    // TRANSLATORS: Do not translate OSD.
> +    title: gettext('Manage Global OSD Flags'),

Translators would need to look at the source code to see this comment.
You could format the string differently and keep 'OSD' hard coded.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-28 11:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-28 11:10 [pve-devel] [PATCH manager] fix #4634: ui: osd: allow to translate the entire string Maximiliano Sandoval
2023-08-28 11:26 ` Fiona Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal