From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] vzdump: fix notifications for backing up VMs with 2+ disks to PBS
Date: Fri, 25 Aug 2023 11:45:12 +0200 [thread overview]
Message-ID: <20230825094512.271010-1-l.wagner@proxmox.com> (raw)
In some situations, such as backing up VMs with 2 or more disks to
PBS, we get passed the backup archive size as a string instead of
as an integer. This led to errors rendering the notification template
down the line.
This commit explicitly casts the data from the task table to an int.
It would be a good idea to actually hunt down the places that produced
the string instead of an integer, but as a quick fix and as a
safeguard against similar lurking errors this approach is fine, IMO.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
Popped up in:
https://forum.proxmox.com/threads/keine-mails-mehr-nach-backup.132675/
PVE/VZDump.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index 2671e3b1..454ab494 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -387,11 +387,11 @@ sub build_guest_table {
my $size = $successful ? $task->{size} : 0;
my $filename = $successful ? $task->{target} : undef;
push @{$table->{data}}, {
- "vmid" => $task->{vmid},
+ "vmid" => int($task->{vmid}),
"name" => $task->{hostname},
"status" => $task->{state},
- "time" => $task->{backuptime},
- "size" => $size,
+ "time" => int($task->{backuptime}),
+ "size" => int($size),
"filename" => $filename,
};
}
--
2.39.2
next reply other threads:[~2023-08-25 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 9:45 Lukas Wagner [this message]
2023-08-25 13:32 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825094512.271010-1-l.wagner@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox