[pve-devel] [PATCH qemu-server] Fix ACPI-suspended VMs resuming after migration

[pve-devel] [PATCH qemu-server] Fix ACPI-suspended VMs resuming after migration

[Filip Schauer]

When migrating a VM that suspended itself via ACPI, it will no longer be
resumed automatically.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
---
 PVE/QemuMigrate.pm |  2 +-
 PVE/QemuServer.pm  | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 506911e..d9aeca8 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -223,7 +223,7 @@ sub prepare {
 	    }
 	}
 
-	$self->{vm_was_paused} = 1 if PVE::QemuServer::vm_is_paused($vmid);
+	$self->{vm_was_paused} = 1 if (PVE::QemuServer::vm_is_paused($vmid) or PVE::QemuServer::vm_is_suspended($vmid));
     }
 
     my ($loc_res, $mapped_res, $missing_mappings_by_node) = PVE::QemuServer::check_local_resources($conf, 1);
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index bf1de17..866b585 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -8599,6 +8599,16 @@ sub vm_is_paused {
     return $qmpstatus && $qmpstatus->{status} eq "paused";
 }
 
+sub vm_is_suspended {
+    my ($vmid) = @_;
+    my $qmpstatus = eval {
+       PVE::QemuConfig::assert_config_exists_on_node($vmid);
+       mon_cmd($vmid, "query-status");
+    };
+    warn "$@\n" if $@;
+    return $qmpstatus && $qmpstatus->{status} eq "suspended";
+}
+
 sub check_volume_storage_type {
     my ($storecfg, $vol) = @_;
 
-- 
2.39.2

Re: [pve-devel] [PATCH qemu-server] Fix ACPI-suspended VMs resuming after migration

[Fiona Ebner]

Am 23.08.23 um 12:58 schrieb Filip Schauer:
> When migrating a VM that suspended itself via ACPI, it will no longer be
> resumed automatically.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>

At a first glance, it seems like the other callers of vm_is_paused()
could also benefit from treating the 'suspended' runstate the same way
as 'paused'. Can you please check that and instead add the check for
'suspended' directly to the vm_is_paused() function? If you can come up
with a good name it might make sense to rename the function too, or at
least add a comment saying that the "paused" does not mean only the
runstate 'paused' but includes other runstates where the VM is paused ;)

And we might want to treat the runstate 'prelaunch' as paused too.

There's also runstates for being paused during certain phases of
migration, but maybe we can ignore them for now. Shouldn't be strictly
required, because of our config locking.

Full list would be here:
https://qemu.readthedocs.io/en/v8.0.0/interop/qemu-qmp-ref.html#qapidoc-85