From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/2] add stricter checks w.r.t. BIOS boot on 4Kn disks
Date: Thu, 10 Aug 2023 12:31:55 +0200 [thread overview]
Message-ID: <20230810103158.436341-1-c.heiss@proxmox.com> (raw)
Booting in legacy BIOS mode on 4Kn disks is generally unsupported, or
rather, simply does not work. The GUI installer already checks that
properly for LVM and ZFS, but is missing it for Btrfs, so extend the
check appropriately.
Further, the TUI installer only checked it for ZFS RAIDs, but not for
LVM and Btrfs. Add proper checks there as well, such that the user gets
immediate feedback early than during the install process.
Seems nobody noticed yet, but apparently 4Kn disks are pretty rare these
days anyway.
Prerequisites
-------------
This series is based on top of
[PATCH installer 0/6] some small, assorted fixes & cleanups
https://lists.proxmox.com/pipermail/pve-devel/2023-August/058708.html
which fixes another 4Kn disk issue.
Testing
-------
Tested by creating a block device with 4K sectorsize using
the following QEMU args:
-device virtio-blk,drive=testdrive4k,logical_block_size=4096,physical_block_size=4096
-drive file=/path/to/4k-testdisk.img,if=none,id=testdrive4k
The 4k-testdisk.img was created with:
qemu-img create -f qcow2 /path/to/4k-testdisk.img 16G
Christoph Heiss (2):
raid setup: btrfs: do not allow legacy BIOS boot on 4Kn disks
tui: disallow legacy BIOS boot from 4Kn disks for all filesystems
Proxmox/Install.pm | 4 +
proxmox-tui-installer/src/main.rs | 2 +-
proxmox-tui-installer/src/setup.rs | 2 +-
proxmox-tui-installer/src/views/bootdisk.rs | 171 ++++++++------------
4 files changed, 74 insertions(+), 105 deletions(-)
--
2.41.0
next reply other threads:[~2023-08-10 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 10:31 Christoph Heiss [this message]
2023-08-10 10:31 ` [pve-devel] [PATCH installer 1/2] raid setup: btrfs: do not allow legacy " Christoph Heiss
2023-08-10 10:31 ` [pve-devel] [PATCH installer 2/2] tui: disallow legacy BIOS boot from 4Kn disks for all filesystems Christoph Heiss
2023-08-23 8:37 ` [pve-devel] applied-series: [PATCH installer 0/2] add stricter checks w.r.t. BIOS boot on 4Kn disks Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810103158.436341-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox