From: Christian Ebner <c.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 pmg-gui 4/4] Revert "fix tracking center with newer proxmox-widget-toolkit"
Date: Wed, 9 Aug 2023 12:55:29 +0200 [thread overview]
Message-ID: <20230809105529.58459-5-c.ebner@proxmox.com> (raw)
In-Reply-To: <20230809105529.58459-1-c.ebner@proxmox.com>
The DateTimeField now defines its own ViewModel, therefore the
MailTrackerFilter container doesn't need one to be inherited to the
child.
This reverts commit 6f3f8ac5cc88ac3c71aed4269688193e5dd6c728.
---
changes since v1:
- not part of v1, reverts hotfix needed by changes introduced by patch
in v1.
js/MailTracker.js | 2 --
1 file changed, 2 deletions(-)
diff --git a/js/MailTracker.js b/js/MailTracker.js
index 1a170d8..52641a4 100644
--- a/js/MailTracker.js
+++ b/js/MailTracker.js
@@ -38,8 +38,6 @@ Ext.define('PMG.MailTrackerFilter', {
},
},
- viewModel: {},
-
getFilterParams: function() {
let me = this;
let param = {};
--
2.39.2
next prev parent reply other threads:[~2023-08-09 10:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 10:55 [pve-devel] [PATCH v2 proxmox-widget-toolkit manager pmg-gui 0/4] #4442: impl firewall log filtering Christian Ebner
2023-08-09 10:55 ` [pve-devel] [PATCH v2 proxmox-widget-toolkit 1/2] fix #4442: adapt DateTimeField to be more declarative Christian Ebner
2023-08-09 10:55 ` [pve-devel] [PATCH v2 proxmox-widget-toolkit 2/2] fix #4442: Extend LogView for firewall datetime filtering Christian Ebner
2023-08-09 10:55 ` [pve-devel] [PATCH v2 manager 3/3] fix #4442: Add date-time filtering for firewall logs Christian Ebner
2023-08-09 10:55 ` Christian Ebner [this message]
2023-11-09 9:22 ` [pve-devel] [PATCH v2 proxmox-widget-toolkit manager pmg-gui 0/4] #4442: impl firewall log filtering Christian Ebner
2023-11-14 15:45 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230809105529.58459-5-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox