From: Alexander Zeidler <a.zeidler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v4 guest-common 3/4] fix #3069: vzdump: schema: add 'pbs-entries-max' property
Date: Fri, 28 Jul 2023 15:28:57 +0200 [thread overview]
Message-ID: <20230728132858.98806-4-a.zeidler@proxmox.com> (raw)
In-Reply-To: <20230728132858.98806-1-a.zeidler@proxmox.com>
configuring pbs-entries-max can avoid failing backups due to a high
amount of files in folders where a folder exclusion is not possible
Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
---
Changes since v3:
Apply Fiona's comments:
* simplify description
Changes since v2:
Apply Fiona's comments:
* rephrase description
* fix dot style nit
Changes since v1:
* improve description
* move description to 'performance' section
* remove arrow alignment
src/PVE/VZDump/Common.pm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
index 31e9fdb..be605af 100644
--- a/src/PVE/VZDump/Common.pm
+++ b/src/PVE/VZDump/Common.pm
@@ -88,6 +88,15 @@ PVE::JSONSchema::register_format('backup-performance', {
default => 16,
optional => 1,
},
+ 'pbs-entries-max' => {
+ description => "Applies to container backups sent to PBS. Limits the number of entries "
+ ."allowed in memory at a given time to avoid unintended OOM situations. Increase it to "
+ ."enable backups of containers with a large amount of files.",
+ type => 'integer',
+ minimum => 1,
+ default => 1048576,
+ optional => 1,
+ },
});
my $confdesc = {
--
2.39.2
next prev parent reply other threads:[~2023-07-28 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 13:28 [pve-devel] [PATCH v4 manager/container/guest-common/docs 0/4] fix #3069: add pbs-entries-max to vzdump.conf Alexander Zeidler
2023-07-28 13:28 ` [pve-devel] [PATCH v4 manager 1/4] fix #3069: vzdump: add property 'performance: pbs-entries-max=N' Alexander Zeidler
2023-07-28 13:28 ` [pve-devel] [PATCH v4 container 2/4]: fix #3069: vzdump: add 'pbs-entries-max' parameter Alexander Zeidler
2023-07-28 13:28 ` Alexander Zeidler [this message]
2023-07-28 13:28 ` [pve-devel] [PATCH v4 docs 4/4] vzdump: mention new parameter 'pbs-entries-max' Alexander Zeidler
2023-09-11 11:38 ` [pve-devel] [PATCH v4 manager/container/guest-common/docs 0/4] fix #3069: add pbs-entries-max to vzdump.conf Alexander Zeidler
2023-09-18 15:05 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728132858.98806-4-a.zeidler@proxmox.com \
--to=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox