From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/2] ui: ldap: add 'Check connection' checkbox as advanced option
Date: Thu, 27 Jul 2023 15:33:18 +0200 [thread overview]
Message-ID: <20230727133341.1009881-3-c.heiss@proxmox.com> (raw)
In-Reply-To: <20230727133341.1009881-1-c.heiss@proxmox.com>
The checkbox is enabled by default for new realms, setting the new
`check-connection` parameter.
Won't effect existing configurations, i.e. being opt-in for them, to not
break existing setups.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
As this uses the newly introduced `check-connection` API parameter, a
bump of libpve-access-control will be needed.
www/manager6/dc/AuthEditLDAP.js | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js
index 2ce16e58c..6f0472ae3 100644
--- a/www/manager6/dc/AuthEditLDAP.js
+++ b/www/manager6/dc/AuthEditLDAP.js
@@ -79,6 +79,21 @@ Ext.define('PVE.panel.LDAPInputPanel', {
},
];
+ me.advancedItems = [
+ {
+ xtype: 'proxmoxcheckbox',
+ fieldLabel: gettext('Check connection'),
+ name: 'check-connection',
+ uncheckedValue: 0,
+ checked: me.isCreate,
+ autoEl: {
+ tag: 'div',
+ 'data-qtip':
+ gettext('Verify connection parameters and bind credentials on save'),
+ },
+ },
+ ];
+
me.callParent();
},
onGetValues: function(values) {
--
2.41.0
next prev parent reply other threads:[~2023-07-27 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 13:33 [pve-devel] [PATCH access-control/manager 0/2] ldap: check bind connection on realm add/update Christoph Heiss
2023-07-27 13:33 ` [pve-devel] [PATCH access-control 1/2] api: domains: add off-by-default `check-connection` parameter Christoph Heiss
2023-07-28 8:29 ` Lukas Wagner
2023-08-01 9:17 ` Christoph Heiss
2023-07-27 13:33 ` Christoph Heiss [this message]
2023-07-28 8:37 ` [pve-devel] [PATCH manager 2/2] ui: ldap: add 'Check connection' checkbox as advanced option Lukas Wagner
2023-08-01 9:18 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727133341.1009881-3-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox