[pve-devel] [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button

[pve-devel] [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button

[Lukas Wagner]

Before, there was zero space between the the grid border line and the
button, making it look a bit odd.

The ListField form component is currently used in the
'User Tag Access' and 'Registered Tags' dialog windows in datacenter
option view.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 www/manager6/form/ListField.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/form/ListField.js b/www/manager6/form/ListField.js
index 61e37f7e..0d0a4f6e 100644
--- a/www/manager6/form/ListField.js
+++ b/www/manager6/form/ListField.js
@@ -144,6 +144,7 @@ Ext.define('PVE.form.ListField', {
 	    text: gettext('Add'),
 	    iconCls: 'fa fa-plus-circle',
 	    handler: 'addLine',
+	    margin: '5 0 0 0',
 	},
     ],
 
-- 
2.39.2

[pve-devel] applied: [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button

[Thomas Lamprecht]

Am 27/07/2023 um 14:47 schrieb Lukas Wagner:
> Before, there was zero space between the the grid border line and the
> button, making it look a bit odd.
> 
> The ListField form component is currently used in the
> 'User Tag Access' and 'Registered Tags' dialog windows in datacenter
> option view.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  www/manager6/form/ListField.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!

FWIW, it might be also look slightly better, and save some space, if we'd
move the add button inside the grid, i.e., at the right side below the last
row. Would also shorten the way one has to move between adding a new tag input
and editing that tag.

Re: [pve-devel] applied: [PATCH manager] ui: form: listfield: add 5px padding between grid and 'Add' button

[Lukas Wagner]

On Wed Aug 2, 2023 at 10:02 AM CEST, Thomas Lamprecht wrote:
> FWIW, it might be also look slightly better, and save some space, if we'd
> move the add button inside the grid, i.e., at the right side below the last
> row. Would also shorten the way one has to move between adding a new tag input
> and editing that tag.

True, that might be a good idea. I'll give that a try when I get around to it.