public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 4/7] tui: install progress: split out prompt logic into own function
Date: Wed, 26 Jul 2023 16:03:58 +0200	[thread overview]
Message-ID: <20230726140406.1048552-5-c.heiss@proxmox.com> (raw)
In-Reply-To: <20230726140406.1048552-1-c.heiss@proxmox.com>

No functional changes.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
 .../src/views/install_progress.rs             | 42 ++++++++++---------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/proxmox-tui-installer/src/views/install_progress.rs b/proxmox-tui-installer/src/views/install_progress.rs
index bd27628..3046a26 100644
--- a/proxmox-tui-installer/src/views/install_progress.rs
+++ b/proxmox-tui-installer/src/views/install_progress.rs
@@ -80,6 +80,27 @@ fn spawn_low_level_installer() -> io::Result<process::Child> {
         .spawn()
 }
 
+fn show_prompt<W: Write + 'static>(siv: &mut Cursive, text: &str, writer: Arc<Mutex<W>>) {
+    yes_no_dialog(
+        siv,
+        "Prompt",
+        text,
+        Box::new({
+            let writer = writer.clone();
+            move |_| {
+                if let Ok(mut writer) = writer.lock() {
+                    let _ = writeln!(writer, "ok");
+                }
+            }
+        }),
+        Box::new(move |_| {
+            if let Ok(mut writer) = writer.lock() {
+                let _ = writeln!(writer);
+            }
+        }),
+    );
+}
+
 fn prepare_for_reboot(siv: &mut Cursive, success: bool, msg: &str) {
     let title = if success { "Success" } else { "Failure" };
 
@@ -159,26 +180,7 @@ fn progress_task(
                 })),
                 UiMessage::Prompt(s) => cb_sink.send({
                     let writer = writer.clone();
-                    Box::new(move |siv| {
-                        yes_no_dialog(
-                            siv,
-                            "Prompt",
-                            &s,
-                            Box::new({
-                                let writer = writer.clone();
-                                move |_| {
-                                    if let Ok(mut writer) = writer.lock() {
-                                        let _ = writeln!(writer, "ok");
-                                    }
-                                }
-                            }),
-                            Box::new(move |_| {
-                                if let Ok(mut writer) = writer.lock() {
-                                    let _ = writeln!(writer);
-                                }
-                            }),
-                        );
-                    })
+                    Box::new(move |siv| show_prompt(siv, &s, writer))
                 }),
                 UiMessage::Progress(ratio, s) => {
                     counter.set(ratio);
-- 
2.41.0





  parent reply	other threads:[~2023-07-26 14:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 14:03 [pve-devel] [PATCH installer 0/7] refactor; improve installation progress Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 1/7] tui: move install progress dialog into own view module Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 2/7] tui: install progress: split out low-level installer spawing into own function Christoph Heiss
2023-07-26 14:03 ` [pve-devel] [PATCH installer 3/7] tui: install progress: split out reboot handling " Christoph Heiss
2023-07-26 14:03 ` Christoph Heiss [this message]
2023-07-26 14:03 ` [pve-devel] [PATCH installer 5/7] tui: install progress: handle errors in ui message loop more gracefully Christoph Heiss
2023-07-26 14:04 ` [pve-devel] [PATCH installer 6/7] low-level: avoid open-coding config reading, parsing and merging Christoph Heiss
2023-07-26 14:04 ` [pve-devel] [PATCH installer 7/7] low-level, tui: count down auto-reboot timeout Christoph Heiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726140406.1048552-5-c.heiss@proxmox.com \
    --to=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal