From: Noel Ullreich <n.ullreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-storage v4; pve-manager 0/4] fix #623: show isos/vztmpl/snippets in subdirs
Date: Fri, 21 Jul 2023 14:23:10 +0200 [thread overview]
Message-ID: <20230721122314.80427-1-n.ullreich@proxmox.com> (raw)
This patch fixes #623, allowing isos/vztmpl/snippets in subdirectories.
This feature is opt-in and can be set from the API, web interface or
with `pvesm`.
changes from v3:
* moved regex that is often used into variables
* enabled going through symlinked directories as well.
NB: there is no logic in this patch that looks for cycles, (so a symlink
to the directory it is in will recurse). This is not a security concern
since it can only recurse as many times as the depth has been set to, it
might however lead to isos/templates/etc appearing multiple times with
cycles in their paths.
Imo, while it is ugly, it is an edgecase of a niche feature that
doesn't break anything, so it's ok.
* changed name of parameter from subdir-depth to scan-depth
Noel Ullreich (3):
recursively go through subdirs to find files
add `scan-depth` option to filesystems
update test for recursive subdir search
src/PVE/Storage.pm | 11 +++++
src/PVE/Storage/CIFSPlugin.pm | 1 +
src/PVE/Storage/CephFSPlugin.pm | 1 +
src/PVE/Storage/DirPlugin.pm | 1 +
src/PVE/Storage/GlusterfsPlugin.pm | 1 +
src/PVE/Storage/NFSPlugin.pm | 1 +
src/PVE/Storage/Plugin.pm | 61 ++++++++++++++++++---------
src/test/filesystem_path_test.pm | 18 ++++++++
src/test/list_volumes_test.pm | 68 ++++++++++++++++++++++++++++++
src/test/parse_volname_test.pm | 40 ++++++++++++++++++
10 files changed, 182 insertions(+), 21 deletions(-)
Noel Ullreich (1):
ui: add field to set subdir-depth in web interface
www/manager6/storage/Base.js | 11 +++++++++++
1 file changed, 11 insertions(+)
--
2.39.2
next reply other threads:[~2023-07-21 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 12:23 Noel Ullreich [this message]
2023-07-21 12:23 ` [pve-devel] [PATCH pve-storage v4 1/3] recursively go through subdirs to find files Noel Ullreich
2023-07-26 9:34 ` Fabian Grünbichler
2023-07-21 12:23 ` [pve-devel] [PATCH pve-storage v4 2/3] add `scan-depth` option to filesystems Noel Ullreich
2023-07-21 12:23 ` [pve-devel] [PATCH pve-storage v4 3/3] update test for recursive subdir search Noel Ullreich
2023-07-21 12:23 ` [pve-devel] [PATCH pve-manager v4 1/1] ui: add field to set subdir-depth in web interface Noel Ullreich
2023-07-25 8:00 ` [pve-devel] [PATCH pve-storage v4; pve-manager 0/4] fix #623: show isos/vztmpl/snippets in subdirs Noel Ullreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721122314.80427-1-n.ullreich@proxmox.com \
--to=n.ullreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox