public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG
Date: Fri, 21 Jul 2023 11:39:08 +0200	[thread overview]
Message-ID: <20230721093910.254158-1-l.wagner@proxmox.com> (raw)

This makes the header bar look a bit less cramped and ensures consistency
if web interfaces are used side-by-side, e.g. on an ultrawide screen.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---

Notes:
    Disadvantage: We loose 8px of vertical space. However, I really think
    this is negligible.

 www/manager6/Workspace.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
index 18d574b7..006e7f29 100644
--- a/www/manager6/Workspace.js
+++ b/www/manager6/Workspace.js
@@ -322,6 +322,7 @@ Ext.define('PVE.StdWorkspace', {
 		    },
 		    border: false,
 		    margin: '2 0 2 5',
+		    height: 38,
 		    items: [
 			{
 			    xtype: 'proxmoxlogo',
@@ -334,6 +335,7 @@ Ext.define('PVE.StdWorkspace', {
 				'font-size': '14px',
 				'line-height': '18px',
 			    },
+			    padding: '0 0 0 5',
 			},
 			{
 			    xtype: 'pveGlobalSearchField',
-- 
2.39.2





             reply	other threads:[~2023-07-21  9:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21  9:39 Lukas Wagner [this message]
2023-07-21  9:39 ` [pve-devel] [PATCH manager 2/3] headerbar: show shortcut for search in emptyText Lukas Wagner
2023-07-21 13:31   ` Thomas Lamprecht
2023-07-21 14:04     ` Lukas Wagner
2023-07-21  9:39 ` [pve-devel] [PATCH manager 3/3] headerbar: center search box, make it adapt to the width of the browser Lukas Wagner
2023-07-21 13:54   ` Thomas Lamprecht
2023-07-21 14:54     ` Lukas Wagner
2023-07-21 14:04 ` [pve-devel] [PATCH manager 1/3] headerbar: use same height and padding for product name as PBS and PMG Thomas Lamprecht
2023-07-24  8:25   ` Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230721093910.254158-1-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal