From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit/manager] improve combogrid default value handling
Date: Wed, 19 Jul 2023 14:11:08 +0200 [thread overview]
Message-ID: <20230719121112.229074-1-d.csapak@proxmox.com> (raw)
the default value for combogrids is '', but we often need to set it to
[], to avoid issues with dirty tracking. Fix this by setting it to [] by
default, making it unnecessary to carry the workaround + comment around
in child classes.
the first patch of pve-manager is a bit unrelated but popped up during
development (can be applied independently)
the second patch of pve-manager is also a bit independent, but it fixes
wrong dirty tracking in the firewall rule edit window iff the widget
toolkit patch is also present
the third manager patch depends on the widget toolkit patch
proxmox-widget-toolkit:
Dominik Csapak (1):
combogrid: initialze value with [] by default
src/form/ComboGrid.js | 2 +-
src/form/NetworkSelector.js | 4 ----
2 files changed, 1 insertion(+), 5 deletions(-)
pve-manager:
Dominik Csapak (3):
ui: ipset: make ip/cidr required
ui: don't set the default value of combogrids to ''
ui: don't set the default value of combogrids to []
www/manager6/form/NodeSelector.js | 5 +----
www/manager6/grid/FirewallRules.js | 2 --
www/manager6/ha/GroupSelector.js | 1 -
www/manager6/panel/IPSet.js | 2 +-
4 files changed, 2 insertions(+), 8 deletions(-)
--
2.30.2
next reply other threads:[~2023-07-19 12:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 12:11 Dominik Csapak [this message]
2023-07-19 12:11 ` [pve-devel] [PATCH widget-toolkit 1/1] combogrid: initialze value with [] by default Dominik Csapak
2023-11-14 8:04 ` [pve-devel] applied: " Thomas Lamprecht
2023-07-19 12:11 ` [pve-devel] [PATCH manager 1/3] ui: ipset: make ip/cidr required Dominik Csapak
2023-07-19 12:11 ` [pve-devel] [PATCH manager 2/3] ui: don't set the default value of combogrids to '' Dominik Csapak
2023-07-19 12:11 ` [pve-devel] [PATCH manager 3/3] ui: don't set the default value of combogrids to [] Dominik Csapak
2023-07-19 12:22 ` [pve-devel] [PATCH widget-toolkit/manager] improve combogrid default value handling Fabian Grünbichler
2023-11-14 15:52 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719121112.229074-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox