From: Christoph Heiss <c.heiss@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer 0/7] tui: add ZFS/Btrfs RAID setup checks
Date: Thu, 13 Jul 2023 11:49:24 +0200 [thread overview]
Message-ID: <20230713094941.475486-1-c.heiss@proxmox.com> (raw)
This introduces the same checks when creating a RAID setup for ZFS and
Btrfs as in the GUI installer.
The main benefit is that the user now gets an error before the setup
dialog can even be closed, instead of during the install process.
Patch #1, #2 and #3 are some cleanups/fixes for things I noticed along
the way, #4 and #5 are prepatory patches. #6 then implements the actual
functionality.
Additionally, #7 contains unit tests for all the logic code paths that
were added, to ensure this cannot be accidentally be regressed.
pve-installer:
Christoph Heiss (7):
gitignore: add cd-info.test
tui: fix small typo in error message
tui: simplify duplicate disk checking logic
tui: deserialize boot type and disk blocksize from runtime env info
tui: improve bootdisk dialog error handling
tui: add RAID setup checks for ZFS/Btrfs
tui: add tests for RAID setup checks
.gitignore | 1 +
proxmox-tui-installer/src/options.rs | 1 +
proxmox-tui-installer/src/setup.rs | 15 +-
proxmox-tui-installer/src/views/bootdisk.rs | 369 ++++++++++++++++++--
4 files changed, 347 insertions(+), 39 deletions(-)
--
2.41.0
next reply other threads:[~2023-07-13 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 9:49 Christoph Heiss [this message]
2023-07-13 9:49 ` [pve-devel] [PATCH installer 1/7] gitignore: add cd-info.test Christoph Heiss
2023-07-13 9:49 ` [pve-devel] [PATCH installer 2/7] tui: fix small typo in error message Christoph Heiss
2023-07-13 9:49 ` [pve-devel] [PATCH installer 3/7] tui: simplify duplicate disk checking logic Christoph Heiss
2023-07-13 9:49 ` [pve-devel] [PATCH installer 4/7] tui: deserialize boot type and disk blocksize from runtime env info Christoph Heiss
2023-07-13 9:49 ` [pve-devel] [PATCH installer 5/7] tui: improve bootdisk dialog error handling Christoph Heiss
2023-07-13 9:49 ` [pve-devel] [PATCH installer 6/7] tui: add RAID setup checks for ZFS/Btrfs Christoph Heiss
2023-07-13 9:49 ` [pve-devel] [PATCH installer 7/7] tui: add tests for RAID setup checks Christoph Heiss
2023-07-21 14:20 ` [pve-devel] partially-applied: [PATCH installer 0/7] tui: add ZFS/Btrfs " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713094941.475486-1-c.heiss@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox