* [pve-devel] [PATCH pve-installer]sys: Invert low storage propt logic
@ 2023-07-13 9:38 Philipp Hufnagl
2023-07-13 14:16 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Hufnagl @ 2023-07-13 9:38 UTC (permalink / raw)
To: pve-devel
Currently there is a bug that you only can install < 8gb when you NOT
accept the warning. This is wrong. A user should have to accept the
warning to install on small systems
Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
---
Proxmox/Sys/Block.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Proxmox/Sys/Block.pm b/Proxmox/Sys/Block.pm
index a5d5506..26085e3 100644
--- a/Proxmox/Sys/Block.pm
+++ b/Proxmox/Sys/Block.pm
@@ -233,7 +233,7 @@ sub partition_bootable_disk {
." installation might not be successful! Continue?"
);
die "root disk '$target_dev' too small (${hdgb} GB < $soft_limit GB), and warning not accepted.\n"
- if $response_ok;
+ if !$response_ok;
}
syscmd("sgdisk -Z ${target_dev}");
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH pve-installer]sys: Invert low storage propt logic
2023-07-13 9:38 [pve-devel] [PATCH pve-installer]sys: Invert low storage propt logic Philipp Hufnagl
@ 2023-07-13 14:16 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-07-13 14:16 UTC (permalink / raw)
To: Proxmox VE development discussion, Philipp Hufnagl
Am 13/07/2023 um 11:38 schrieb Philipp Hufnagl:
> Currently there is a bug that you only can install < 8gb when you NOT
> accept the warning. This is wrong. A user should have to accept the
> warning to install on small systems
>
> Signed-off-by: Philipp Hufnagl <p.hufnagl@proxmox.com>
> ---
> Proxmox/Sys/Block.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, but reworded the commit subject including the s/popt/prompt/
fix, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-13 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 9:38 [pve-devel] [PATCH pve-installer]sys: Invert low storage propt logic Philipp Hufnagl
2023-07-13 14:16 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox