From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server 2/2] qmeventd: further improve getting vmid from PID
Date: Mon, 10 Jul 2023 09:58:25 +0200 [thread overview]
Message-ID: <20230710075825.15882-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230710075825.15882-1-f.ebner@proxmox.com>
by also expecting the ".scope" part and trying the next entry if it is
not present instead of immediately failing.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
qmeventd/qmeventd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c
index 503bce69..7e9b2354 100644
--- a/qmeventd/qmeventd.c
+++ b/qmeventd/qmeventd.c
@@ -128,12 +128,12 @@ get_vmid_from_pid(pid_t pid)
errno = 0;
char *endptr = NULL;
vmid = strtoul(vmid_start, &endptr, 10);
+ if (!endptr || strncmp(endptr, ".scope", 6)) {
+ continue;
+ }
if (errno != 0) {
fprintf(stderr, "error parsing vmid for %d: %s\n", pid, strerror(errno));
vmid = 0;
- } else if (*endptr != '.') {
- fprintf(stderr, "unexpected cgroup entry %s\n", buf);
- vmid = 0;
}
goto ret;
--
2.39.2
next prev parent reply other threads:[~2023-07-10 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 7:58 [pve-devel] [PATCH qemu-server 1/2] qmeventd: improve getting vmid from PID in presence of legacy cgroup entries Fiona Ebner
2023-07-10 7:58 ` Fiona Ebner [this message]
2023-07-10 8:20 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710075825.15882-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox