From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH proxmox-widget-toolkit 1/1] apt: drop ChangeLogUrl
Date: Tue, 4 Jul 2023 11:45:06 +0200 [thread overview]
Message-ID: <20230704094507.92567-4-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20230704094507.92567-1-f.gruenbichler@proxmox.com>
it's not returned anymore by the corresponding backends, since fetching
changelogs is now fully delegated to `apt`.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Notes:
could benefit from a Breaks on old versions of pve-manager/pmg-api ,
but not strictly required, it will simply allow attempting to fetch
changelogs for packages where the backend already said there is none
src/node/APT.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/node/APT.js b/src/node/APT.js
index 739aaf3..231e866 100644
--- a/src/node/APT.js
+++ b/src/node/APT.js
@@ -2,7 +2,7 @@ Ext.define('apt-pkglist', {
extend: 'Ext.data.Model',
fields: [
'Package', 'Title', 'Description', 'Section', 'Arch', 'Priority', 'Version', 'OldVersion',
- 'ChangeLogUrl', 'Origin',
+ 'Origin',
],
idProperty: 'Package',
});
@@ -108,8 +108,8 @@ Ext.define('Proxmox.node.APT', {
});
let show_changelog = function(rec) {
- if (!rec?.data?.ChangeLogUrl || !rec?.data?.Package) {
- console.debug('cannot show changelog, missing Package and/or ChangeLogUrl', rec);
+ if (!rec?.data?.Package) {
+ console.debug('cannot show changelog, missing Package', rec);
return;
}
@@ -154,7 +154,7 @@ Ext.define('Proxmox.node.APT', {
text: gettext('Changelog'),
selModel: sm,
disabled: true,
- enableFn: rec => !!rec?.data?.ChangeLogUrl && !!rec?.data?.Package,
+ enableFn: rec => !!rec?.data?.Package,
handler: (b, e, rec) => show_changelog(rec),
});
--
2.39.2
next prev parent reply other threads:[~2023-07-04 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 9:45 [pve-devel] [PATCH pve-manager/pmg-api/proxmox-backup/pwt 0/4] APT changelog switch-over Fabian Grünbichler
2023-07-04 9:45 ` [pve-devel] [PATCH pmg-api 1/1] apt: use `apt changelog` for changelog fetching Fabian Grünbichler
2023-07-04 9:45 ` [pve-devel] [PATCH proxmox-backup " Fabian Grünbichler
2023-07-04 9:45 ` Fabian Grünbichler [this message]
2023-11-13 17:18 ` [pve-devel] applied: [PATCH proxmox-widget-toolkit 1/1] apt: drop ChangeLogUrl Thomas Lamprecht
2023-11-14 7:04 ` Fabian Grünbichler
2023-07-04 9:45 ` [pve-devel] [PATCH manager 1/1] apt: use `apt changelog` for changelog fetching Fabian Grünbichler
2023-11-14 8:30 ` [pve-devel] applied-series: [PATCH pve-manager/pmg-api/proxmox-backup/pwt 0/4] APT changelog switch-over Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704094507.92567-4-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox