public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check
@ 2023-06-27  7:48 Fiona Ebner
  2023-08-30  9:13 ` Fiona Ebner
  2023-08-30  9:27 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Fiona Ebner @ 2023-06-27  7:48 UTC (permalink / raw)
  To: pve-devel

instead of claiming that the storage is not online.

Would've made the issue fixed by b27da68 ("cifs: fix check connection
call") more obvious, because (the UI passes along an empty string for
domain if not set and) the smbclient call returns that status with
> -W ''
in Bookworm.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/Storage/CIFSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/Storage/CIFSPlugin.pm b/src/PVE/Storage/CIFSPlugin.pm
index 4cab2e1..2184471 100644
--- a/src/PVE/Storage/CIFSPlugin.pm
+++ b/src/PVE/Storage/CIFSPlugin.pm
@@ -285,7 +285,7 @@ sub check_connection {
 
     if (my $err = $@) {
 	die "$out_str\n" if defined($out_str) &&
-	    ($out_str =~ m/NT_STATUS_(ACCESS_DENIED|LOGON_FAILURE)/);
+	    ($out_str =~ m/NT_STATUS_(ACCESS_DENIED|INVALID_PARAMETER|LOGON_FAILURE)/);
 	return 0;
     }
 
-- 
2.39.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check
  2023-06-27  7:48 [pve-devel] [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check Fiona Ebner
@ 2023-08-30  9:13 ` Fiona Ebner
  2023-08-30  9:27 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2023-08-30  9:13 UTC (permalink / raw)
  To: pve-devel

Ping

Am 27.06.23 um 09:48 schrieb Fiona Ebner:
> instead of claiming that the storage is not online.
> 
> Would've made the issue fixed by b27da68 ("cifs: fix check connection
> call") more obvious, because (the UI passes along an empty string for
> domain if not set and) the smbclient call returns that status with
>> -W ''
> in Bookworm.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>





^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check
  2023-06-27  7:48 [pve-devel] [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check Fiona Ebner
  2023-08-30  9:13 ` Fiona Ebner
@ 2023-08-30  9:27 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-08-30  9:27 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fiona Ebner

Am 27/06/2023 um 09:48 schrieb Fiona Ebner:
> instead of claiming that the storage is not online.
> 
> Would've made the issue fixed by b27da68 ("cifs: fix check connection
> call") more obvious, because (the UI passes along an empty string for
> domain if not set and) the smbclient call returns that status with
>> -W ''
> in Bookworm.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  src/PVE/Storage/CIFSPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-30  9:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-27  7:48 [pve-devel] [PATCH storage] cifs: bubble up NT_STATUS_INVALID_PARAMETER during connection check Fiona Ebner
2023-08-30  9:13 ` Fiona Ebner
2023-08-30  9:27 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal