From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH eslint/manager/wt/pmg-gui/proxmox-backup v3] change eslint
Date: Fri, 23 Jun 2023 09:08:42 +0200 [thread overview]
Message-ID: <20230623070847.1672322-1-d.csapak@proxmox.com> (raw)
from 'eslint' to 'pve-eslint' to avoid a conflict with debians 'eslint'
package which ships the same binary
to avoid breakage, pull out the eslint binary into a make variable and
use pve-eslint if it exists, and eslint otherwise
changes from v2:
* use $(shell command) instead of $(wildcard), thanks @thomas for the
suggestions, this makes it shorter + we don't have to use the full
path
* added Suggested-by trailers
changes from v1:
* use $(ESLINT)
* use $(wildcard) make builtin to check if pve-eslint exists, use eslint as fallback
* introduce defines.mk in pmg-gui for ESLINT variable
pve-eslint:
Dominik Csapak (1):
change binary name from 'eslint' to 'pve-eslint'
debian/links | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
pve-manager:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defines.mk | 2 ++
www/manager6/Makefile | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
proxmox-widget-toolkit:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
src/Makefile | 6 +++---
src/defines.mk | 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
pmg-gui:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defines.mk | 1 +
js/Makefile | 6 ++++--
js/mobile/Makefile | 3 ++-
3 files changed, 7 insertions(+), 3 deletions(-)
create mode 100644 defines.mk
proxmox-backup:
Dominik Csapak (1):
try using 'pve-eslint' if it exists
defines.mk | 1 +
www/Makefile | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
--
2.30.2
next reply other threads:[~2023-06-23 7:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 7:08 Dominik Csapak [this message]
2023-06-23 7:08 ` [pve-devel] [PATCH eslint v3 1/1] change binary name from 'eslint' to 'pve-eslint' Dominik Csapak
2023-08-30 9:42 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-23 7:08 ` [pve-devel] [PATCH manager v3 1/1] try using 'pve-eslint' if it exists Dominik Csapak
2023-06-24 15:45 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-23 7:08 ` [pve-devel] [PATCH widget-toolkit " Dominik Csapak
2023-06-24 15:51 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-23 7:08 ` [pve-devel] [PATCH pmg-gui " Dominik Csapak
2023-08-30 9:42 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-23 7:08 ` [pve-devel] [PATCH proxmox-backup " Dominik Csapak
2023-06-24 15:51 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623070847.1672322-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox