From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] pve7to8: add reminder comment for noout_wanted variable
Date: Wed, 21 Jun 2023 18:19:48 +0200 [thread overview]
Message-ID: <20230621161948.116285-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230621161948.116285-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
Applies to the master branch. It's enough the have the reminder here,
stable would even need a different patch because of changed context.
PVE/CLI/pve7to8.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index 6b51e98e..d988c715 100644
--- a/PVE/CLI/pve7to8.pm
+++ b/PVE/CLI/pve7to8.pm
@@ -542,6 +542,7 @@ sub check_ceph {
log_warn("unable to determine overall Ceph daemon versions!");
} elsif (keys %$overall_versions == 1) {
log_pass("single running overall version detected for all Ceph daemon types.");
+ # TODO: needs to be set to 1 in the stable branch each time! - find better solution?
$noout_wanted = 0; # off post-upgrade, on pre-upgrade
} elsif (keys $ceph_versions_simple->{overall}->%* != 1) {
log_warn("overall version mismatch detected, check 'ceph versions' output for details!");
--
2.39.2
next prev parent reply other threads:[~2023-06-21 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 16:19 [pve-devel] [PATCH stable-7 manager] pve7to8: enable noout before upgrade Fiona Ebner
2023-06-21 16:19 ` Fiona Ebner [this message]
2023-06-21 16:42 ` [pve-devel] applied: [PATCH manager] pve7to8: add reminder comment for noout_wanted variable Thomas Lamprecht
2023-06-21 16:42 ` [pve-devel] applied: [PATCH stable-7 manager] pve7to8: enable noout before upgrade Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621161948.116285-2-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox