From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 1/1] ui: cloudinit: align default value for package upgrades with backend again
Date: Wed, 21 Jun 2023 12:04:33 +0200 [thread overview]
Message-ID: <20230621100433.36525-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230621100433.36525-1-f.ebner@proxmox.com>
The default in Proxmox VE 7 was true and it was decided to keep that
and avoid a breaking change.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
www/manager6/qemu/CloudInit.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/qemu/CloudInit.js b/www/manager6/qemu/CloudInit.js
index 0e06d962..03d06d9c 100644
--- a/www/manager6/qemu/CloudInit.js
+++ b/www/manager6/qemu/CloudInit.js
@@ -290,7 +290,7 @@ Ext.define('PVE.qemu.CloudInit', {
header: gettext('Upgrade packages'),
iconCls: 'fa fa-archive',
renderer: Proxmox.Utils.format_boolean,
- defaultValue: '',
+ defaultValue: 1,
editor: {
xtype: 'proxmoxWindowEdit',
subject: gettext('Upgrade packages on boot'),
@@ -298,7 +298,7 @@ Ext.define('PVE.qemu.CloudInit', {
xtype: 'proxmoxcheckbox',
name: 'ciupgrade',
uncheckedValue: 0,
- defaultValue: 0,
+ value: 1, // serves as default value, using defaultValue is not enough
fieldLabel: gettext('Upgrade packages'),
labelWidth: 140,
},
--
2.39.2
next prev parent reply other threads:[~2023-06-21 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 10:04 [pve-devel] [PATCH-SERIES qemu-server/manager] restore PVE 7 default for cloudinit package upgrades Fiona Ebner
2023-06-21 10:04 ` [pve-devel] [PATCH qemu-server 1/2] schema: cloudinit: document default for ciupgrade Fiona Ebner
2023-06-21 10:04 ` [pve-devel] [PATCH qemu-server 2/2] cloudinit: restore previous default for package upgrades Fiona Ebner
2023-06-21 10:04 ` Fiona Ebner [this message]
2023-06-21 10:47 ` [pve-devel] applied-series: [PATCH-SERIES qemu-server/manager] restore PVE 7 default for cloudinit " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621100433.36525-4-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox