public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH installer] gui: make abort button unsensitive on last panel
Date: Wed, 21 Jun 2023 11:57:42 +0200	[thread overview]
Message-ID: <20230621095742.54009-1-m.sandoval@proxmox.com> (raw)

It makes no sense from a UX point of view to abort an install that's
already finished.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/proxinstall b/proxinstall
index 6d13892..bf88b31 100755
--- a/proxinstall
+++ b/proxinstall
@@ -213,6 +213,7 @@ sub create_main_window {
     $gtk_state->{next_btn} = $next_btn;
     $gtk_state->{progress_bar} = Gtk3::ProgressBar->new();
     $gtk_state->{progress_status} = Gtk3::Label->new('');
+    $gtk_state->{abort_btn} = $abort;
 
     Proxmox::UI::init_gtk($gtk_state, $iso_env);
 
@@ -1522,6 +1523,10 @@ sub create_extract_view {
 	return $raw_html;
     };
 
+    # It does not make sense to Abort the install at this point, whether it
+    # succeded or failed makes no difference.
+    $gtk_state->{abort_btn}->set_sensitive(0);
+
     if ($err) {
 	Proxmox::UI::display_html("fail.htm");
 	# suppress "empty" error as we got some case where the user choose to abort on a prompt,
-- 
2.39.2





             reply	other threads:[~2023-06-21  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  9:57 Maximiliano Sandoval [this message]
2023-06-21 10:51 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230621095742.54009-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal