From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 installer 1/1] fix #4643: show a confirmation dialog when clicking abort
Date: Wed, 21 Jun 2023 10:55:05 +0200 [thread overview]
Message-ID: <20230621085505.28910-2-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20230621085505.28910-1-m.sandoval@proxmox.com>
Note that unlike the rest of the file, we connect to the response signal
instead of using Gtk3::Dialog->run, the reason is that run blocks the
main loop used by GTK and this undesirable to the point where
Gtk3::Dialog->run was removed for GTK 4.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
proxinstall | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 6d13892..600d5a5 100755
--- a/proxinstall
+++ b/proxinstall
@@ -180,7 +180,19 @@ sub create_main_window {
my $abort = Gtk3::Button->new('_Abort');
$abort->set_can_focus(0);
$cmdbox->pack_start($abort, 0, 0, 10);
- $abort->signal_connect(clicked => sub { app_quit(-1); });
+ $abort->signal_connect(clicked => sub {
+ my $msg = 'Abort Installation';
+ my $secondary_text = 'Are you sure you want to abort the installation?';
+ my $dialog = Gtk3::MessageDialog->new($window, 'modal', 'question', 'yes-no', $msg);
+ $dialog->format_secondary_text($secondary_text);
+ $dialog->signal_connect(response => sub {
+ my ($dialog, $response) = @_;
+
+ $dialog->close();
+ app_quit(-1) if $response eq 'yes';
+ });
+ $dialog->present();
+ });
my $vbox2 = Gtk3::Box->new('vertical', 0);
$hbox->add($vbox2);
--
2.39.2
next prev parent reply other threads:[~2023-06-21 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 8:55 [pve-devel] [PATCH v2 installer 0/1] " Maximiliano Sandoval
2023-06-21 8:55 ` Maximiliano Sandoval [this message]
2023-06-21 10:30 ` [pve-devel] applied: [PATCH v2 installer 1/1] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621085505.28910-2-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox