From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager v2 1/5] ui: resource map tree: make 'ok' status clearer
Date: Wed, 21 Jun 2023 09:41:38 +0200 [thread overview]
Message-ID: <20230621074142.742461-1-d.csapak@proxmox.com> (raw)
by changing into 'mapping matches host data' which indicates that the
configured values matches the host information
also for the pci and usb map selectors
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/PCIMapSelector.js | 2 +-
www/manager6/form/USBMapSelector.js | 2 +-
www/manager6/tree/ResourceMapTree.js | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/www/manager6/form/PCIMapSelector.js b/www/manager6/form/PCIMapSelector.js
index 4dca62ea..1bc73ec0 100644
--- a/www/manager6/form/PCIMapSelector.js
+++ b/www/manager6/form/PCIMapSelector.js
@@ -48,7 +48,7 @@ Ext.define('PVE.form.PCIMapSelector', {
let me = this;
if (!Ext.isArray(value) || !value?.length) {
- return `<i class="fa fa-check-circle good"></i> ${gettext('Mapping OK')}`;
+ return `<i class="fa fa-check-circle good"></i> ${gettext('Mapping matches host data')}`;
}
let checks = [];
diff --git a/www/manager6/form/USBMapSelector.js b/www/manager6/form/USBMapSelector.js
index 990ef30f..6a33754a 100644
--- a/www/manager6/form/USBMapSelector.js
+++ b/www/manager6/form/USBMapSelector.js
@@ -34,7 +34,7 @@ Ext.define('PVE.form.USBMapSelector', {
let me = this;
if (!Ext.isArray(value) || !value?.length) {
- return `<i class="fa fa-check-circle good"></i> ${gettext('Mapping OK')}`;
+ return `<i class="fa fa-check-circle good"></i> ${gettext('Mapping matches host data')}`;
}
let errors = [];
diff --git a/www/manager6/tree/ResourceMapTree.js b/www/manager6/tree/ResourceMapTree.js
index df50b63a..02717042 100644
--- a/www/manager6/tree/ResourceMapTree.js
+++ b/www/manager6/tree/ResourceMapTree.js
@@ -228,7 +228,7 @@ Ext.define('PVE.tree.ResourceMapTree', {
} else {
let state = value ? 'good' : 'critical';
iconCls = PVE.Utils.get_health_icon(state, true);
- status = value ? gettext("OK") : record.data.errmsg || Proxmox.Utils.unknownText;
+ status = value ? gettext("Mapping matches host data") : record.data.errmsg || Proxmox.Utils.unknownText;
}
return `<i class="fa ${iconCls}"></i> ${status}`;
},
--
2.30.2
next reply other threads:[~2023-06-21 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 7:41 Dominik Csapak [this message]
2023-06-21 7:41 ` [pve-devel] [PATCH manager v2 2/5] ui: pci map edit: reintroduce warnings checks Dominik Csapak
2023-06-21 7:41 ` [pve-devel] [PATCH manager v2 3/5] ui: pci/usb map edit: improve new host mappings dialog Dominik Csapak
2023-06-21 7:41 ` [pve-devel] [PATCH manager v2 4/5] ui: pci map edit: fix typos in warnings and use gettexts Dominik Csapak
2023-06-21 7:41 ` [pve-devel] [PATCH manager v2 5/5] ui: pci/usb mapping: rework mapping panel for better user experience Dominik Csapak
2023-06-21 8:07 ` [pve-devel] applied: [PATCH manager v2 1/5] ui: resource map tree: make 'ok' status clearer Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621074142.742461-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox