public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] make harddisk options dialog modal
@ 2023-06-20  9:34 Maximiliano Sandoval
  0 siblings, 0 replies; only message in thread
From: Maximiliano Sandoval @ 2023-06-20  9:34 UTC (permalink / raw)
  To: pve-devel

Modal dialogs block the user from interacting with the main window.

We already do this with message dialogs so for consistency sake, we set
the harddisk options dialog as modal. Note that one can see weird
behaviors when interacting with the window behind the dialog in certain
scenarios.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 proxinstall | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/proxinstall b/proxinstall
index fe0239f..f32abd2 100755
--- a/proxinstall
+++ b/proxinstall
@@ -2291,6 +2291,8 @@ sub create_hdoption_view {
     my $dialog = Gtk3::Dialog->new();
 
     $dialog->set_title("Harddisk options");
+    $dialog->set_modal(1);
+    $dialog->set_transient_for($window);
 
     $dialog->add_button("_OK", 1);
 
-- 
2.39.2





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-06-20  9:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-20  9:34 [pve-devel] [PATCH installer] make harddisk options dialog modal Maximiliano Sandoval

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal